SCHED-1071: Local NVMe support#874
Conversation
check region/platform/preset for validation small fix one mount_path to rule them all if nvme then enable hc script fixes and xfs based on info in #proj-local-disks
theyoprst
left a comment
There was a problem hiding this comment.
couple of things:
-
cloud_init.yaml.tftpl-mdadm --createwithout--forcemay hang on recycled nodes with existing superblocks. consider runningwipefs -aon each disk before creating the array, or pass--force -
cloud_init.yaml.tftpl:136- NVMe detection vianvme list+ awk is fragile across tool versions.lsblk -d -n -o NAME,TRAN | awk '$2=="nvme" {print "/dev/"$1}'would be more reliable -
cloud_init.yaml.tftpl:153- hard fail onDISK_COUNT < 2. is 2+ disks guaranteed for all supported presets? if a single-disk config is possible, could just format directly without mdadm -
cloud_init.yaml.tftpl:210- mount_path interpolated without quoting in runcmd:prepare-disks.sh ${local_nvme_mount_path}. minor since paths are validated, but quoting is cheap -
flux_release_nodesets.tf:29-37/main.tf:148-155-source_type,host_path,filesystem_typefields added to jail_submounts but only used in the nodesets template path. thesource_type == "host_path"branch in the template is dead code today. is this pre-work for a future PR? if so, might be cleaner to defer -
no validation that
local_nvme.mount_pathdoesn't collide with other jail submount paths or system mounts
otherwise looks solid - good validation chain, init container mount checks, and per-nodeset design is clean
Add support for (raw) local NVMe disks.