Modernization, Phase 6: Refactor more Verifier Tests#298
Merged
OdysseusLives merged 2 commits intomainfrom Feb 16, 2026
Merged
Conversation
…DependencyLockPluginWithCoreVerifierSpec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactorings for
DependencyLockPluginWithCoreVerifierSpectests, which are similar to the previous PR #297Also extracts a common
VerifierOutputAssertionsBasebase class to hold common dependency versifier assertions.These are done to help show that while the testfile changes, the implementation and outcome remains the same.
This will be helpful as the next PR introduces implementation changes to support configuration-cache-ability for the
DependencyResolutionVerifier.