Merged
Conversation
wakingrufus
reviewed
Jan 26, 2026
...ules-gradle-plugin/src/main/kotlin/com/netflix/nebula/archrules/gradle/ArchrulesExtension.kt
Outdated
Show resolved
Hide resolved
Member
|
Looks good so far, just 1 comment |
emilyyuan03
force-pushed
the
priority-override
branch
from
b82f47a to
2b6c958
Compare
wakingrufus
reviewed
Jan 27, 2026
|
|
||
| fun priority(priority: String) { | ||
| try { | ||
| this.priority = Priority.valueOf(priority) |
Member
There was a problem hiding this comment.
I think we can avoid throwing an exception here. instead, get the set of valid values, check if the arg is in that set, if not, lets log a warning, and just not set the priority
emilyyuan03
force-pushed
the
priority-override
branch
from
accc801 to
3fecbe4
Compare
wakingrufus
reviewed
Jan 27, 2026
| var priority = result.getPriority(); | ||
| String ruleClassName = ruleClass.getClass().getCanonicalName(); | ||
| for (Map.Entry<String, Priority> override : overrides.entrySet()) { | ||
| if (ruleClassName.startsWith(override.getKey())) { |
Member
There was a problem hiding this comment.
i don't think we should do this based on class name, since rules within the same class often have different priorities. I think it should be based on rule name, and use equalsIgnoreCase to compare... WDYT?
wakingrufus
reviewed
Jan 27, 2026
|
|
||
| fun priority(priority: String) { | ||
| try { | ||
| this.priority = Priority.valueOf(priority) |
Member
There was a problem hiding this comment.
This still needs refactoring to avoid the exception
add .editorconfig to enforce style
wakingrufus
previously approved these changes
Jan 28, 2026
Member
|
Lgtm! Can you add some docs to the readme for this feature? Thanks! |
emilyyuan03
force-pushed
the
priority-override
branch
from
f29aa44 to
f601585
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.