Add ruleClass api for priority override#52
Merged
emilyyuan03 merged 3 commits intomainfrom Feb 2, 2026
Merged
Conversation
wakingrufus
reviewed
Jan 29, 2026
| String ruleClassName = ruleClass.getClass().getCanonicalName(); | ||
| for (Map.Entry<String, Priority> override : overrides.entrySet()) { | ||
| String overrideRuleName = override.getKey(); | ||
| if (ruleClassName.startsWith(overrideRuleName) || id.equals(overrideRuleName)) { |
Member
There was a problem hiding this comment.
if both the rule class and rule name have overrides, we should prefer the rule name override.
I think a test case for this could be added, and this impl will have to change to specify this behavior
wakingrufus
reviewed
Feb 2, 2026
| consoleDetailsThreshold.set(Priority.valueOf(priority)) | ||
| } | ||
|
|
||
| fun rule(ruleName: String, action: Action<RuleConfig>) { |
Member
There was a problem hiding this comment.
lets leave rule in place for backward compatibility. you can mark it as @Deprecated and still create the new ruleName that does the same thing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.