Open
Conversation
wakingrufus
reviewed
Mar 9, 2026
|
|
||
| @ParameterizedTest | ||
| @EnumSource(SupportedGradleVersion::class) | ||
| fun `test skip source set`(gradleVersion: SupportedGradleVersion) { |
Member
There was a problem hiding this comment.
There is a test for this in ArchrulesRunnerPluginTest already.
- Remove unused @disabled import - Add missing enforceArchRules SKIPPED assertion to 'test variant resolution' - Add task outcome assertions to 'test proto integration' - Add 'test empty rules project' to verify no-rules library doesn't break consumer - Add 'test fail mode with low threshold' to cover LOW priority failure path Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
sullis
force-pushed
the
sullis/improve-int-test-coverage
branch
from
2d8feab to
ab783e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands and tightens
IntegrationTestcoverage for the Gradle plugin by improving assertions in existing tests and adding focused scenarios for empty-rule and low-threshold behavior.What changed
@Disabledimport.test variant resolutionby asserting:code-to-check:enforceArchRulesisSKIPPED.test proto integrationby asserting task outcomes for::code-to-check:checkArchRulesMain:code-to-check:checktest empty rules project(acrossSupportedGradleVersion) to verify projects with no defined rules still execute checks successfully.test fail mode with low thresholdto cover failure behavior whenfailureThreshold("LOW")is configured.Why
This closes coverage gaps by validating both successful execution paths and explicit failure behavior, while ensuring expected Gradle task outcomes are asserted instead of only checking warning output.