Conversation
…ct configuration cache breaking patterns in @TaskAction methods
wakingrufus
reviewed
Dec 11, 2025
...ment/src/archRules/java/com/netflix/nebula/archrules/gradleplugins/GradleTaskActionRule.java
Outdated
Show resolved
Hide resolved
…gs by leveraging automatic message generation (#23)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces
archrules-gradle-plugin-developmentmodule (proposed name, happy to change)Adds
GradleTaskActionRuleto thearchrules-gradle-plugin-developmentmodule to detect Gradle 10 breaking changes in task implementations.The rules provide detection of two patterns that break configuration cache:
Projectobject in@TaskActionmethods viagetProject()calls, Project method/field access, orProject-typed fields
getTaskDependencies()in@TaskActionmethods.Both patterns will cause runtime errors in Gradle 10+ and should be refactored to use task properties configured at configuration time instead of execution time.