fix: Handle git@ urls that don't end in .git#204
Open
rahulsom wants to merge 1 commit intonebula-plugins:mainfrom
Open
fix: Handle git@ urls that don't end in .git#204rahulsom wants to merge 1 commit intonebula-plugins:mainfrom
git@ urls that don't end in .git#204rahulsom wants to merge 1 commit intonebula-plugins:mainfrom
Conversation
rahulsom
force-pushed
the
handle-git-urls
branch
4 times, most recently
from
683ce51 to
ea8bb29
Compare
Prior to this, something like would log a warning. ``` git@github.com:username/nebula-publishing-plugin ``` This change handles it correctly. Also, remove `@CompileDynamic`.
rahulsom
force-pushed
the
handle-git-urls
branch
from
ea8bb29 to
a8de475
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this, something like would log a warning.
This change handles it correctly.