Persist the old preview URLs for future jobs#5
Open
ChristianRimondi wants to merge 2 commits intomasterfrom
Open
Persist the old preview URLs for future jobs#5ChristianRimondi wants to merge 2 commits intomasterfrom
ChristianRimondi wants to merge 2 commits intomasterfrom
Conversation
7317ef1 to
4c4ba82
Compare
c094340 to
6c66649
Compare
38bc819 to
d978141
Compare
6c66649 to
ba2e049
Compare
d978141 to
fffc5d8
Compare
This uses the labels added in #4 to generate and persist a json file with a list of previews info associated with the containers removed during the current orb execution. The file format is something like: ``` { "PR_NUMBER": { "preview_url": "https://SUBDOMAIN.DOMAIN", "branch": "BRANCH" } } ``` This adopts the same approach used in #3, so the way of retrieving the persisted file is the same: ``` steps: - attach_workspace: # Must be absolute path or relative path from working_directory at: /tmp/workspace - run: | cat /tmp/workspace/deleted-previews.json ``` To generate the json file it uses `docker inspect` to retrieve the containers info in a json format and `jq` to parse this info: ``` # This selects only the containers with a label named `pull-request` map(select(.Config.Labels["pull-request"])) # This maps the container info returned by `docker inspect` into an array of # `{"key": "PR_NUMBER", "value": {"branch": "BRANCH", "preview_url": "PREVIEW_URL"}}` map({ key: .Config.Labels["pull-request"], value: { branch: .Config.Labels["branch"], preview_url: "https://\(.Config.Labels["subdomain"]).<< parameters.domain >>" } }) # Convert an array `[{"key": k, "value": v}]` into an object `{k: v}` from_entries ```
ba2e049 to
79d607e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This uses the labels added in #4 to generate and persist a json file with a list of previews info associated with the containers removed during the current orb execution. The file format is something like:
This adopts the same approach used in #3, so the way of retrieving the persisted file is the same:
To generate the json file it uses
docker inspectto retrieve the containers info in a json format andjqto parse this info: