Update component values based on LCSC numbers, add Gerber notes.#7
Open
grantek wants to merge 1 commit intonecroware:mainfrom
Open
Update component values based on LCSC numbers, add Gerber notes.#7grantek wants to merge 1 commit intonecroware:mainfrom
grantek wants to merge 1 commit intonecroware:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These component changes are based on the LCSC numbers C706412 and C107186 - the old values are not common component values.
I updated the values in the schematic and clicked "Update PCB from schematic" in the PCB editor, this created some diffs in polygons that I'm not sure about, I can remove the PCB file (and/or the schematic file) from this PR if needed.