Skip to content

Use set instead of list for arcs_executed, fixes poor performance #1901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 4, 2024
Merged

Use set instead of list for arcs_executed, fixes poor performance #1901

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
052db24
Use set instead of list for arcs_executed, fixes poor performance
turibe Dec 3, 2024
6fb281e
Merge branch 'master' into tu-performance-report-arcs
nedbat Dec 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion coverage/results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ def arcs_missing(self) -> list[TArc]:
"""Returns a sorted list of the un-executed arcs in the code."""
missing = (
p for p in self.arc_possibilities
if p not in self.arcs_executed
if p not in self.arcs_executed_set
and p[0] not in self.no_branch
and p[1] not in self.excluded
)
Expand Down
Loading