Improve Warning Suppression Performance by Using set
#1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devdanzin
reviewed
Mar 4, 2025
coverage/control.py
Outdated
| self._warn_unimported_source = True | ||
| self._warn_preimported_source = check_preimported | ||
| self._no_warn_slugs: list[str] = [] | ||
| self._no_warn_slugs: set[str] = [] |
There was a problem hiding this comment.
The initialization is still done with an empty list, should use an empty set instead.
There was a problem hiding this comment.
sure, updated now, thanks for pointing that out
|
Thanks! I'm not sure we can measure the speed increase, but it is better philosophically. |
|
@allrob23 How should I credit you in the contributors file? |
|
This PR is part of an ongoing research project. So may I respond to this question later, when and if our paper is published? |
|
Now I'm curious about the topic of the paper! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR optimizes the way warning suppression is handled by changing
_no_warn_slugsfrom alistto aset. This improves performance when checking if a warning should be suppressed, reducing lookup complexity from O(n) to O(1) on average. Additionally, using asetensures uniqueness, preventing duplicate warning slugs from being added.Changes
list[str]withset[str]for_no_warn_slugs.set(self.config.disable_warnings)..append(slug)with.add(slug)to maintain set behavior.Why?