-
-
Couldn't load subscription status.
- Fork 458
run: Support system signal as a coverage report dump trigger. #1998
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
35233a5
cd2a914
b4f3467
0858fb0
b2b23c4
5d0acca
a89c789
3f8ef2f
824e788
f3bcee1
ed22d06
31920ff
ce9dfe9
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -10,9 +10,11 @@ | |||||
| import os | ||||||
| import os.path | ||||||
| import shlex | ||||||
| import signal | ||||||
| import sys | ||||||
| import textwrap | ||||||
| import traceback | ||||||
| import types | ||||||
|
|
||||||
| from typing import cast, Any, NoReturn | ||||||
|
|
||||||
|
|
@@ -227,7 +229,15 @@ class Opts: | |||||
| "", "--version", action="store_true", | ||||||
| help="Display version information and exit.", | ||||||
| ) | ||||||
|
|
||||||
| dump_signal = optparse.make_option( | ||||||
| '', '--dump_signal', action='store', metavar='DUMP_SIGNAL', | ||||||
|
||||||
| '', '--dump_signal', action='store', metavar='DUMP_SIGNAL', | |
| '', '--dump-signal', action='store', metavar='DUMP_SIGNAL', |
Options use hyphens, not underscores.
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Keep these items alphabetized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, I think this should be called "save signal" instead of "dump signal" throughout.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These make_option definitions are in rough alphabetical order, so this should be further up.