add unit tests to cover module, request factory, and response factory.#25
Open
abacaphiliac wants to merge 1 commit intoneeckeloo:masterfrom
abacaphiliac:add-tests
Open
add unit tests to cover module, request factory, and response factory.#25abacaphiliac wants to merge 1 commit intoneeckeloo:masterfrom abacaphiliac:add-tests
abacaphiliac wants to merge 1 commit intoneeckeloo:masterfrom
abacaphiliac:add-tests
Conversation
Contributor
abacaphiliac
commented
Dec 15, 2016
- add unit tests to cover module, request factory, and response factory.
- update module doc-block.
3 similar comments
Contributor
Author
|
ouch. the --prefer-lowest builds bit me ; ) |
…. update module doc-block.
3 similar comments
Contributor
Author
|
@neeckeloo ok, got the --prefer-lowest tests to pass. i was trying to cheat and use a real Application instance instead of mocking the interface and those instances are different between ZF2 and ZF3. who would've thought? : P are you interested in only sending coverage to coveralls for a single build? and if so, which one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.