com.unity.netcode@1.0.15

## [1.0.15] - 2023-07-27

### Changed

* Updated com.unity.entities dependency to 1.0.14
* Use of non required TempJob allocation and use Allocator.Temp instead.

### Fixed

* Runtime EntityQuery leaks and reduce runtime memory pressure due to continuously allocating queries without disposing.
* Reduced memory usage in Editor tests, by avoiding allocating queries continuously in hot paths.

Author: Unity Technologies

CHANGELOG.md

@@ -1,6 +1,19 @@
 # Changelog
 
 
+## [1.0.15] - 2023-07-27
+
+### Changed
+
+* Updated com.unity.entities dependency to 1.0.14
+* Use of non required TempJob allocation and use Allocator.Temp instead.
+
+### Fixed
+
+* Runtime EntityQuery leaks and reduce runtime memory pressure due to continuously allocating queries without disposing.
+* Reduced memory usage in Editor tests, by avoiding allocating queries continuously in hot paths.
+
+
 ## [1.0.12] - 2023-06-19
 
 ### Changed
@@ -37,6 +50,8 @@
 
 * exceptions when NetworkRequestListen and/or. NetworkRequestConnect are handled and proper handling of multiple (erroneous) requests presents.
 * A problem with InterpolatedTick, going back and not recovering correctly in presence of large application, either the server or the client, stalls (i.e after loading).
+* `MultiplayerPlayModeWindow > Dump Packet Logs` now works more reliably, now works with NUnit tests, and dump files are named with more context.
+* Fixed bug in `GhostSendSystem` that caused it to not replicate ghosts when enabling packet dumps. `GhostValuesAreSerialized_WithPacketDumpsEnabled` test added.
 
 
 ## [1.0.8] - 2023-04-17

Editor/MultiplayerPlayModeWindow.cs

@@ -973,9 +973,8 @@ static void DisconnectSpecificClient(EntityManager entityManager, NetworkId netw
         {
             entityManager.CompleteAllTrackedJobs();
             using var activeConnectionsQuery = entityManager.CreateEntityQuery(ComponentType.ReadOnly<NetworkId>(), ComponentType.Exclude<NetworkStreamRequestDisconnect>());
-
-            using var entities = activeConnectionsQuery.ToEntityArray(Allocator.Temp);
-            using var networkIds = activeConnectionsQuery.ToComponentDataArray<NetworkId>(Allocator.Temp);
+            var entities = activeConnectionsQuery.ToEntityArray(Allocator.Temp);
+            var networkIds = activeConnectionsQuery.ToComponentDataArray<NetworkId>(Allocator.Temp);
             for (var i = 0; i < entities.Length; i++)
             {
                 if (networkIds[i].Value == networkId.Value)
@@ -990,8 +989,7 @@ static void DisconnectAllClients(EntityManager entityManager, NetworkStreamDisco
         {
             entityManager.CompleteAllTrackedJobs();
             using var activeConnectionsQuery = entityManager.CreateEntityQuery(ComponentType.ReadOnly<NetworkId>(), ComponentType.Exclude<NetworkStreamRequestDisconnect>());
-
-            using var entities = activeConnectionsQuery.ToEntityArray(Allocator.Temp);
+            var entities = activeConnectionsQuery.ToEntityArray(Allocator.Temp);
             for (var i = 0; i < entities.Length; i++)
             {
                 // TODO - Convert to batch when API supports 1 NetworkStreamRequestDisconnect for n entities.

Runtime/Analytics/NetCodeAnalyticsState.cs

@@ -21,7 +21,7 @@ public static int GetPlayerCount()
 
         public static uint GetUpdateLength(World world)
         {
-            var query = world.EntityManager.CreateEntityQuery(ComponentType.ReadOnly<GhostSendSystemAnalyticsData>());
+            using var query = world.EntityManager.CreateEntityQuery(ComponentType.ReadOnly<GhostSendSystemAnalyticsData>());
             if (query.CalculateEntityCount() != 1)
             {
                 return 0;

Runtime/Authoring/Hybrid/GhostAuthoringComponentBaker.cs

@@ -199,10 +199,8 @@ partial class GhostAuthoringBakingSystem : SystemBase
 
         protected override void OnCreate()
         {
-            base.OnCreate();
-
             // Query to get all the root entities baked before
-            m_NoLongerBakedRootEntities = EntityManager.CreateEntityQuery(new EntityQueryDesc
+            m_NoLongerBakedRootEntities = GetEntityQuery(new EntityQueryDesc
             {
                 None = new []
                 {
@@ -218,7 +216,7 @@ protected override void OnCreate()
             m_NoLongerBakedRootEntitiesMask = m_NoLongerBakedRootEntities.GetEntityQueryMask();
 
             // Query to get all the root entities baked before
-            m_GhostEntities = EntityManager.CreateEntityQuery(new EntityQueryDesc
+            m_GhostEntities = GetEntityQuery(new EntityQueryDesc
             {
                 All = new []
                 {

Runtime/ClientServerWorld/ClientServerBootstrap.cs

@@ -560,7 +560,7 @@ public void OnCreate(ref SystemState state)
                     var world = World.All[i];
                     if (world.IsClient())
                     {
-                        var driver = world.EntityManager.CreateEntityQuery(ComponentType.ReadOnly<NetworkStreamDriver>());
+                        using var driver = world.EntityManager.CreateEntityQuery(ComponentType.ReadOnly<NetworkStreamDriver>());
                         UnityEngine.Assertions.Assert.IsFalse(driver.IsEmpty);
                         var driverData = driver.ToComponentDataArray<NetworkStreamDriver>(Allocator.Temp);
                         UnityEngine.Assertions.Assert.IsTrue(driverData.Length == 1);

Runtime/Connection/DriverMigrationSystem.cs

@@ -102,13 +102,12 @@ public int StoreWorld(World sourceWorld)
 
             driverMap.Add(ticket, default);
 
-            var driverSingletonQuery = sourceWorld.EntityManager.CreateEntityQuery(ComponentType.ReadWrite<NetworkStreamDriver>());
+            using var driverSingletonQuery = sourceWorld.EntityManager.CreateEntityQuery(ComponentType.ReadWrite<NetworkStreamDriver>());
             ref var driverSingleton = ref driverSingletonQuery.GetSingletonRW<NetworkStreamDriver>().ValueRW;
             driverSingletonQuery.CompleteDependency();
-            driverSingletonQuery.Dispose();
             Store(driverSingleton.StoreMigrationState(), ticket);
 
-            var filter = sourceWorld.EntityManager.CreateEntityQuery(typeof(NetworkStreamConnection));
+            using var filter = sourceWorld.EntityManager.CreateEntityQuery(typeof(NetworkStreamConnection));
             var backupWorld = new World(sourceWorld.Name, sourceWorld.Flags);
 
             backupWorld.EntityManager.MoveEntitiesFrom(sourceWorld.EntityManager, filter);

Runtime/Connection/NetworkStreamDriver.cs

@@ -166,7 +166,8 @@ public Entity Connect(EntityManager entityManager, NetworkEndpoint endpoint, Ent
             if (DriverStore.DriversCount != 1)
                 throw new InvalidOperationException("Too many NetworkDriver created for the client. Only one NetworkDriver instance should exist");
             var builder = new EntityQueryBuilder(Allocator.Temp).WithAll<NetworkSnapshotAck>();
-            if (!entityManager.CreateEntityQuery(builder).IsEmpty)
+            using var query = entityManager.CreateEntityQuery(builder);
+            if (!query.IsEmpty)
                 throw new InvalidOperationException("Connection to server already initiated, only one connection allowed at a time.");
 #endif
 #if UNITY_EDITOR || !UNITY_CLIENT

Runtime/Debug/NetCodeDebugConfig.cs

@@ -42,8 +42,8 @@ internal partial struct DebugConnections : ISystem
         [BurstCompile]
         public void OnCreate(ref SystemState state)
         {
-            m_ConnectionsQueryWithout = state.EntityManager.CreateEntityQuery(new EntityQueryBuilder(Allocator.Temp).WithAll<NetworkStreamConnection>().WithNone<EnablePacketLogging>());
-            m_ConnectionsQueryWith = state.EntityManager.CreateEntityQuery(new EntityQueryBuilder(Allocator.Temp).WithAll<NetworkStreamConnection>().WithAll<EnablePacketLogging>());
+            m_ConnectionsQueryWithout = state.GetEntityQuery(new EntityQueryBuilder(Allocator.Temp).WithAll<NetworkStreamConnection>().WithNone<EnablePacketLogging>());
+            m_ConnectionsQueryWith = state.GetEntityQuery(new EntityQueryBuilder(Allocator.Temp).WithAll<NetworkStreamConnection>().WithAll<EnablePacketLogging>());
         }
 
         public void OnUpdate(ref SystemState state)
@@ -78,13 +78,6 @@ public void OnUpdate(ref SystemState state)
                 state.EntityManager.RemoveComponent<EnablePacketLogging>(m_ConnectionsQueryWith);
             }
         }
-
-        [BurstCompile]
-        public void OnDestroy(ref SystemState state)
-        {
-            m_ConnectionsQueryWithout.Dispose();
-            m_ConnectionsQueryWith.Dispose();
-        }
     }
 #endif
 }

Runtime/Rpc/RpcCommandRequest.cs

@@ -89,7 +89,7 @@ public partial class RpcCommandRequestSystemGroup : ComponentSystemGroup
         protected override void OnCreate()
         {
             base.OnCreate();
-            m_Query = EntityManager.CreateEntityQuery(ComponentType.ReadOnly<SendRpcCommandRequest>());
+            m_Query = GetEntityQuery(ComponentType.ReadOnly<SendRpcCommandRequest>());
         }
         protected override void OnUpdate()
         {

Runtime/Snapshot/GhostCollectionSystem.cs

@@ -182,13 +182,13 @@ public void OnCreate(ref SystemState state)
 
             entityQueryBuilder.Reset();
             entityQueryBuilder.WithAll<NetworkStreamInGame>();
-            m_InGameQuery = state.EntityManager.CreateEntityQuery(entityQueryBuilder);
+            m_InGameQuery = state.GetEntityQuery(entityQueryBuilder);
             entityQueryBuilder.Reset();
             entityQueryBuilder.WithAll<NetworkId>();
-            m_AllConnectionsQuery = state.EntityManager.CreateEntityQuery(entityQueryBuilder);
+            m_AllConnectionsQuery = state.GetEntityQuery(entityQueryBuilder);
             entityQueryBuilder.Reset();
             entityQueryBuilder.WithAll<Prefab, GhostType>().WithNone<GhostPrefabRuntimeStrip>();
-            m_RegisterGhostTypesQuery = state.EntityManager.CreateEntityQuery(entityQueryBuilder);
+            m_RegisterGhostTypesQuery = state.GetEntityQuery(entityQueryBuilder);
 
             if (!SystemAPI.TryGetSingletonEntity<CodeGhostPrefab>(out m_CodePrefabSingleton))
                 m_CodePrefabSingleton = state.EntityManager.CreateSingletonBuffer<CodeGhostPrefab>();
@@ -207,8 +207,6 @@ public void OnDestroy(ref SystemState state)
                 m_AllComponentTypes.Dispose();
             if (m_StableHashToComponentTypeIndex.IsCreated)
                 m_StableHashToComponentTypeIndex.Dispose();
-            m_InGameQuery.Dispose();
-            m_AllConnectionsQuery.Dispose();
             state.EntityManager.DestroyEntity(m_CollectionSingleton);
 #if UNITY_EDITOR || NETCODE_DEBUG
             m_PredictionErrorNames.Dispose();