Fix aggressive "rm -rf" in uninstall target #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix numeric compare Signed-off-by: nega <[email protected]> * rename sub-test makefile Signed-off-by: nega <[email protected]> * add test artifact to "clean" Signed-off-by: nega <[email protected]> * add test artifacts to gitignore Signed-off-by: nega <[email protected]> --------- Signed-off-by: nega <[email protected]>
* Fixes shell expression in checkstyle target An incorrect shell expression was preventing the `make checkstyle UPDATE=1` from applying the perltidy fixes. Signed-off-by: nega <[email protected]> * add *.orig (and *.rej) to the gitignore Signed-off-by: nega <[email protected]> --------- Signed-off-by: nega <[email protected]>
…ug or enhancement request. Signed-off-by: Henry Cox <[email protected]>
If --all flag is specified, then capture from both runtime (.gcda) and bare compile-time (.gcno) files - i.e., include unused .gcno files which have no corresponding runtime data. Signed-off-by: Henry Cox <[email protected]>
…nk to first TLA line in 'file table' flat view. Signed-off-by: Henry Cox <[email protected]>
See 'genhtml --select-script ...' Add file name and line number to 'select' callback. Clarify '--select-script' documentation. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
… thorough testing. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Fix bug that caused per-testcase summary to not be generated. Signed-off-by: Henry Cox <[email protected]>
hey applied. Reformat/clarify report format man page. Fix typo in warning message. Signed-off-by: Henry Cox <[email protected]>
Enable coverage collection for more tests/more test types. Feature to force parallel execution - even if there is only one task - to improve testability. Signed-off-by: Henry Cox <[email protected]>
llvm-cov seems to generate them when translating from profile to lcov format. The same effect can be achieved via '--omit-lines' - but filter option is easier for users, especially as this is a common case. Signed-off-by: Henry Cox <[email protected]>
of whether their 'hit' count is zero or not. This may be useful in LLVM-generated coverage data which tends to contain large number of these - distorting statistics. Signed-off-by: Henry Cox <[email protected]>
User expected to have some effect - or would not have passed the option. Without this check, user may see some unexpected results that look a lot like tool bugs (...we ignored some option). Signed-off-by: Henry Cox <[email protected]>
Add infrastructure to control retries. Signed-off-by: Henry Cox <[email protected]>
Enable exclusions and substitutions in perl2lcov. Warn if coverage DB is empty. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Fix issues exposed by those tests. Signed-off-by: Henry Cox <[email protected]>
That is: use environment variable rather than hard-coded '/etc' or '/usr/local/etc'. Signed-off-by: Henry Cox <[email protected]>
can happen only if there is an implementation bug (not a user error or data inconsistency) Signed-off-by: Henry Cox <[email protected]>
Can simplify user's Jenkins scripts. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Only emit explantory text on the first message. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Add corresponding error message tests. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
all the tracefiles in the indicated subdirectory (aggregating them). This feature makes it much easier to find and reuse baseline and/or current coverage data which was is held in a per-testsuite DB. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
…st-project#355) Handle spaces in path/filename. See linux-test-project#350. Signed-off-by: Henry Cox <[email protected]>
…[..], shell=True, [..])` (fixes linux-test-project#350) (linux-test-project#356) * xml2lcovutil.py: Extract variable lcov Signed-off-by: Sebastian Pipping <[email protected]> * xml2lcov: Stop allowing command injection via xml2lcovutil.py Signed-off-by: Sebastian Pipping <[email protected]> * py2lcov: Stop allowing command injection Signed-off-by: Sebastian Pipping <[email protected]> --------- Signed-off-by: Sebastian Pipping <[email protected]>
…oject#357) Signed-off-by: Sebastian Pipping <[email protected]>
GitHub regression fixes. linux-test-project#343, linux-test-project#348 Signed-off-by: Henry Cox <[email protected]>
…oject#359) Signed-off-by: Henry Cox <[email protected]>
…inux-test-project#360) Signed-off-by: Henry Cox <[email protected]>
…inux-test-project#361) identical to the corresponding branch: reduce verbosity/noise. Signed-off-by: Henry Cox <[email protected]>
… default filters only if '--filter ...' option was not used. (linux-test-project#362) Error if both '--filter' and '--no-markers' are specified (or or the other - not both). Action is unchanged (filter out excluded regions) if no filter options are specified. Signed-off-by: Henry Cox <[email protected]>
…for corresponding 'date' table entries in HTML report. (linux-test-project#363) Signed-off-by: Henry Cox <[email protected]>
…ation). Signed-off-by: Henry Cox <[email protected]>
…t#365) If user explicitly asks to use a particular verion (...by having it in her environment): use it. Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
…ect#366) Signed-off-by: Sebastian Pipping <[email protected]>
Clarification + fix typos Signed-off-by: Henry Cox <[email protected]> Signed-off-by: Henry Cox <[email protected]>
* Test updates: portability, common utility, fix typo Signed-off-by: Henry Cox <[email protected]>
…inux-test-project#374) Addresses linux-test-project#372 Signed-off-by: Henry Cox <[email protected]>
…inux-test-project#375) * README: Fix list indentation that changed halfway in the list * README: Add missing Perl dependency TimeDate for Date::Parse for command genhtml. Not to be mixed up with DateTime, which is also needed (but already documented). * run_test_suite.yml: Treat CPAN TimeDate as a direct dependency Signed-off-by: Sebastian Pipping <[email protected]>
Signed-off-by: Henry Cox <[email protected]>
lcov invokes geninfo but didn't provide it with the user's --tempdir option value (if specified); pass it down. Signed-off-by: Paul Smith <[email protected]>
…project#382) Signed-off-by: Henry Cox <[email protected]>
…t#378) (linux-test-project#383) * extract.sh: Use "grep -F" where possible * extract.sh: Set ${USER} when not set or empty in environment Signed-off-by: Sebastian Pipping <[email protected]>
…ject#386) Signed-off-by: Henry Cox <[email protected]>
* Add location to error message. * Update default version ID * fix spelling Signed-off-by: Henry Cox <[email protected]>
This makes things more clear when looking at `find`, "shell", and `make` syntax on one line (and removes double slashes in the output.) Signed-off-by: nega <[email protected]>
`make uninstall` deletes `$(PREFIX)/share` instead of `$(PREFIX)/share/lcov` with `rm -rf`. This is surprising. This patch fixes that unconditional delete by deleting `$(PREFIX)/share/lcov`. This is still not optimal, and wouldn't be necessary if the tests were not installed. This patch also cleans up the installed manpages. Signed-off-by: nega <[email protected]>
This eliminates the need for `rm -rf` in the uninstall target. Signed-off-by: nega <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lcov's
make uninstallwiped my~/.local/share. This was... surprising.