Skip to content

Naively truncate log messages#117

Open
mucha55 wants to merge 1 commit into4.xfrom
naively-truncate-log-messages
Open

Naively truncate log messages#117
mucha55 wants to merge 1 commit into4.xfrom
naively-truncate-log-messages

Conversation

@mucha55
Copy link
Contributor

@mucha55 mucha55 commented Nov 12, 2020

This branch may not be merged in as-is, it's more to provide a dev- version on packagist for ListingService to see if this truncation resolves logging problems

@mucha55 mucha55 requested a review from alexberryman November 12, 2020 19:27
@mucha55 mucha55 self-assigned this Nov 12, 2020
@mucha55
Copy link
Contributor Author

mucha55 commented Nov 12, 2020

This is probably fine for pretty-printed output, but for single-line message, it may not be aggressive enough. I just pulled a typical error log line (with a short message) and it comes in at ~7K characters (most of it from the long error trace), leaving ~9K characters to work with, which would be halved to 4500 characters if userspace does something like ->error($throwable->getMessage(), 'exception' => $throwable), which is not uncommon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants