Skip to content

[Snyk] Upgrade axios from 0.18.1 to 0.30.2 #693

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nejidevelops wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[Snyk] Upgrade axios from 0.18.1 to 0.30.2 #693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion course-04/exercises/c4-client-master/package.json
100755 → 100644
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"axios": "^0.18.1",
"axios": "^0.30.2",
Copy link

@gemini-code-assist gemini-code-assist bot Oct 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This upgrade to axios v0.30.2 introduces a breaking change that will likely cause your API calls to fail.

Starting with axios v0.19.0, JavaScript objects are automatically serialized to JSON for requests with Content-Type: 'application/json'. Your current code in src/api/todos-api.ts manually stringifies the data for POST and PATCH requests, for example:

// src/api/todos-api.ts:24
const response = await Axios.post(`${apiEndpoint}/todos`,  JSON.stringify(newTodo), { /* ... */ });

With the new axios version, this will lead to double-encoded JSON, breaking your backend integration.

To fix this, you must remove the JSON.stringify() calls in createTodo and patchTodo functions and pass the objects directly.

Example for createTodo:

// src/api/todos-api.ts
export async function createTodo(
  idToken: string,
  newTodo: CreateTodoRequest
): Promise<Todo> {
  const response = await Axios.post(`${apiEndpoint}/todos`, newTodo, { // No JSON.stringify
    headers: {
      'Content-Type': 'application/json',
      'Authorization': `Bearer ${idToken}`
    }
  })
  return response.data.item
}

The same change is needed for patchTodo. This is a critical fix required for the app to function after this dependency upgrade.

"dateformat": "^3.0.3",
"immutability-helper": "^3.0.1",
"react": "^16.8.6",
Expand Down