Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"axios": "^1.6.4",
"axios": "^1.13.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Upgrade leaves lockfile pinned to axios 1.6.4

The dependency entry here bumps axios to ^1.13.2, but the lockfile still resolves axios to 1.6.4 (see package-lock.json lines 3495-3502). Any install that uses the lockfile (e.g., npm ci in CI/prod) will keep pulling 1.6.4, so the intended security update never lands and the project remains on the vulnerable version.

Useful? React with 👍 / 👎.

"dateformat": "^3.0.3",
"immutability-helper": "^3.0.0",
"react": "^17.0.2",
Expand All @@ -23,7 +23,7 @@
"@types/react-router-dom": "^5.1.8",
"@types/styled-components": "^5.1.11",
"auth0-js": "^9.16.2",
"axios": "^1.6.4",
"axios": "^1.13.2",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The axios package is a runtime dependency and is already correctly listed in the dependencies section. Including it in devDependencies as well is redundant and can lead to confusion. It should be removed from devDependencies.

"typescript": ">=3.8.0"
},
"scripts": {
Expand Down