Skip to content

Add basic auth support for Redmine instances#14

Open
lchojnacki wants to merge 1 commit intonekeal:masterfrom
lchojnacki:add_basic_auth_support
Open

Add basic auth support for Redmine instances#14
lchojnacki wants to merge 1 commit intonekeal:masterfrom
lchojnacki:add_basic_auth_support

Conversation

@lchojnacki
Copy link

Overview

  • Introduces support for basic authentication for Redmine instances by allowing configuration of username and password.
  • Updates documentation to describe how to configure basic auth credentials.
  • Adds a new dependency for type-checking the requests library.

Comment on lines +134 to +136
For Redmine instances that use basic authentication, you can specify the credentials using `basic_auth_user` and
`basic_auth_password` properties in the instance configuration:

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer keeping description of this section generic, and explicitely enumerating supported instances.
This way it will be easy to add support for basic auth to the rest of instances in the future? What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants