Jlc/add nelc custom dependencies#3
Merged
johanseto merged 4 commits intoopen-release/teak.nelpfrom Nov 4, 2025
Merged
Conversation
Collaborator
andrey-canon
left a comment
There was a problem hiding this comment.
You set the base branch (open-release/teak.nelp) from release/teak, which is incorrect. The correct base is teak-design-tokens. Please retarget your PR to a Paragon-compatible branch—start with teak-design-tokens.
package.json
Outdated
| "@edx/brand": "npm:@openedx/brand-openedx@^1.2.2", | ||
| "@edx/brand": "github:nelc/brand-openedx#open-release/teak.nelp", | ||
| "@edx/frontend-component-footer": "^14.6.0", | ||
| "@edx/frontend-component-header": "^6.2.0", |
aa86baf to
ef618fd
Compare
33f06f0 to
bdf8543
Compare
bdf8543 to
6ac04fd
Compare
andrey-canon
requested changes
Oct 31, 2025
andrey-canon
approved these changes
Oct 31, 2025
Collaborator
andrey-canon
left a comment
There was a problem hiding this comment.
LGTM
2025-10-31.13-10-58.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
Add nelc dependencies.
Current status: UNBlocked
Frontend platform is being not compatible due logging app initialization.
jira story: https://edunext.atlassian.net/browse/FUTUREX-1463?atlOrigin=eyJpIjoiNTNhNDRjYWQ4MTFjNDIyYTg3MWY0OTkyOWM4YWQ3MGYiLCJwIjoiaiJ9
After using an appropriate paragon package Frontend platform starts working
Issue # 1530
How to test language selector
npm installMFE_CONFIG["ENABLE_HEADER_LANG_SELECTOR"] = TrueScreencast.from.31-10-25.11.27.55.webm
How to branding and primary color customization
npm installScreencast.from.31-10-25.11.27.40.webm
How to test ProfileDataModal
npm installScreencast.from.31-10-25.11.25.49.webm