drop sensio/framework-extra-bundle #2256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominicLuidold
approved these changes
Apr 6, 2024
DjordyKoert
added a commit
that referenced
this pull request
Apr 6, 2024
* phpstan installation * remove old symfony 4.2 code * deprecate unused property * remove symfony 5.3 BC layer * remove bleedingEdge * remove phpstan/extension-installer * add phpstan-strict-rules * rename to phpstan.dist.neon * add phpstan job * add phpstan-symfony application loader * remove phpVersion * source code fixes PHPStan level 1 * test code fixes PHPStan level 1 * fix strings used for int Asserts * revert util change for PHP < 8.1 * remove mixed type usage * remove __callStatic * add baseline command * PHPStan level 2 * cleanup ControllerReflector class * remove bitwise operator usage * PHPStan level 3 * PHPStan level 4 * PHPStan level 5 * bump deprecation version Co-authored-by: Dominic Luidold <[email protected]> * Create dependabot.yml * Bump actions/cache from 3 to 4 Bumps [actions/cache](https://github.com/actions/cache) from 3 to 4. - [Release notes](https://github.com/actions/cache/releases) - [Changelog](https://github.com/actions/cache/blob/main/RELEASES.md) - [Commits](actions/cache@v3...v4) --- updated-dependencies: - dependency-name: actions/cache dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> * drop sensio/framework-extra-bundle (#2256) * add phpstan-baseline description * remove config section * move PropertyDescriberInterface errors to baseline * add phpstan.neon to gitignore --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Dominic Luidold <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
W0rma
reviewed
Apr 12, 2024
| - name: Remove packages not compatible Symfony 7 | ||
| if: ${{ inputs.symfony-version == '7.0.*' }} | ||
| run: composer remove --dev --no-update friendsofsymfony/rest-bundle sensio/framework-extra-bundle | ||
| run: composer remove --dev --no-update friendsofsymfony/rest-bundle |
There was a problem hiding this comment.
@DjordyKoert FYI https://github.com/FriendsOfSymfony/FOSRestBundle/releases/tag/3.7.0 added support fro symfony 7 to friendsofsymfony/rest-bundle
There was a problem hiding this comment.
I just noticed that #2257 already changed the CI config. Sorry for the noise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Dropping" support for
sensio/framework-extra-bundle