Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/Fhp/Action/GetBalance.php
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ public function getBalances()
return $this->response;
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
/** @var BaseSegment $hisals */
Expand All @@ -115,7 +114,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
}
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Action/GetDepotAufstellung.php
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,6 @@ public function getDepotWert(): float
return $this->depotWert;
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
/** @var HIWPDS $hiwpds */
Expand All @@ -125,7 +124,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
}
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Action/GetSEPAAccounts.php
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@ public function getAccounts(): array
return $this->accounts;
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
/** @var BaseSegment $hispas */
Expand All @@ -64,7 +63,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
}
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
1 change: 0 additions & 1 deletion lib/Fhp/Action/GetSEPADirectDebitParameters.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,6 @@ public static function getHixxesSegmentName(string $directDebitType, bool $singl
}
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
$this->hidxes = $bpd->requireLatestSupportedParameters(static::getHixxesSegmentName($this->directDebitType, $this->singleDirectDebit));
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Action/GetStatementOfAccount.php
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,6 @@ public function getStatement(): StatementOfAccount
return $this->statement;
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
$this->bankName = $bpd->getBankName();
Expand All @@ -171,7 +170,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
}
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Action/GetStatementOfAccountXML.php
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,6 @@ public function getBookedXML(): array
return $this->xml;
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
if ($upd === null) {
Expand Down Expand Up @@ -149,7 +148,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
}
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Action/SendSEPARealtimeTransfer.php
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ public static function create(SEPAAccount $account, string $painMessage, bool $a
return $result;
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
/** @var HIIPZSv1|HIIPZSv2 $hiipzs */
Expand Down Expand Up @@ -92,7 +91,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
return $hkipz;
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Action/SendSEPATransfer.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ public static function create(SEPAAccount $account, string $painMessage): SendSE
return $result;
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
//ANALYSE XML FOR RECEIPTS AND PAYMENT DATE
Expand Down Expand Up @@ -110,7 +109,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
return $segment;
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
1 change: 0 additions & 1 deletion lib/Fhp/MT940/Dialect/PostbankMT940.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class PostbankMT940 extends MT940
{
public const DIALECT_ID = 'https://hbci.postbank.de/banking/hbci.do';

/** {@inheritdoc} */
public function extractStructuredDataFromRemittanceLines($descriptionLines, string &$gvc, array &$rawLines, array $transaction): array
{
// z.B bei Zinsen o.ä. ist alles leer
Expand Down
1 change: 0 additions & 1 deletion lib/Fhp/MT940/Dialect/SpardaMT940.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ class SpardaMT940 extends MT940
{
public const DIALECT_ID = 'https://fints.bankingonline.de/fints/FinTs30PinTanHttpGate';

/** {@inheritdoc} */
public function extractStructuredDataFromRemittanceLines($descriptionLines, string &$gvc, array &$rawLines, array $transaction): array
{
$otherInfo = [];
Expand Down
9 changes: 0 additions & 9 deletions lib/Fhp/Model/FlickerTan/StartCode.php
Original file line number Diff line number Diff line change
Expand Up @@ -68,17 +68,11 @@ protected function __construct(array $ctrlBytes, string $data)
$this->headerHighBit = '1';
}

/**
* {@inheritDoc}
*/
public function toHex(): string
{
return $this->getHeaderHex() . implode('', $this->controlBytes) . $this->getDataHex();
}

/**
* {@inheritDoc}
*/
public function getLuhnChecksum(): int
{
$luhn = 0;
Expand All @@ -89,9 +83,6 @@ public function getLuhnChecksum(): int
return $luhn;
}

/**
* {@inheritDoc}
*/
public function __debugInfo(): ?array
{
return [
Expand Down
17 changes: 0 additions & 17 deletions lib/Fhp/Model/NoPsd2TanMode.php
Original file line number Diff line number Diff line change
Expand Up @@ -16,13 +16,11 @@ final class NoPsd2TanMode implements TanMode
{
public const ID = -1;

/** {@inheritdoc} */
public function getId(): int
{
return self::ID;
}

/** {@inheritdoc} */
public function getName(): string
{
return 'No PSD2/TANs supported';
Expand All @@ -33,91 +31,76 @@ public function isProzessvariante2(): bool
return false;
}

/** {@inheritdoc} */
public function isDecoupled(): bool
{
return false;
}

/** {@inheritdoc} */
public function getChallengeLabel(): string
{
return '';
}

/** {@inheritdoc} */
public function getMaxChallengeLength(): int
{
return 0;
}

/** {@inheritdoc} */
public function getMaxTanLength(): int
{
return 0;
}

/** {@inheritdoc} */
public function getTanFormat(): int
{
return 0;
}

/** {@inheritdoc} */
public function needsTanMedium(): bool
{
return false;
}

/** {@inheritdoc} */
public function getSmsAbbuchungskontoErforderlich(): bool
{
return false;
}

/** {@inheritdoc} */
public function getAuftraggeberkontoErforderlich(): bool
{
return false;
}

/** {@inheritdoc} */
public function getChallengeKlasseErforderlich(): bool
{
return false;
}

/** {@inheritdoc} */
public function getAntwortHhdUcErforderlich(): bool
{
return false;
}

/** {@inheritdoc} */
public function getMaxDecoupledChecks(): int
{
throw new \RuntimeException('Only allowed for decoupled TAN modes');
}

/** {@inheritdoc} */
public function getFirstDecoupledCheckDelaySeconds(): int
{
throw new \RuntimeException('Only allowed for decoupled TAN modes');
}

/** {@inheritdoc} */
public function getPeriodicDecoupledCheckDelaySeconds(): int
{
throw new \RuntimeException('Only allowed for decoupled TAN modes');
}

/** {@inheritdoc} */
public function allowsManualConfirmation(): bool
{
throw new \RuntimeException('Only allowed for decoupled TAN modes');
}

/** {@inheritdoc} */
public function allowsAutomatedPolling(): bool
{
throw new \RuntimeException('Only allowed for decoupled TAN modes');
Expand Down
6 changes: 0 additions & 6 deletions lib/Fhp/PaginateableAction.php
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,6 @@ abstract class PaginateableAction extends BaseAction

/**
* @deprecated Beginning from PHP7.4 __unserialize is used for new generated strings, then this method is only used for previously generated strings - remove after May 2023
*
* {@inheritdoc}
*/
public function serialize(): string
{
Expand All @@ -53,8 +51,6 @@ public function __serialize(): array

/**
* @deprecated Beginning from PHP7.4 __unserialize is used for new generated strings, then this method is only used for previously generated strings - remove after May 2023
*
* {@inheritdoc}
*/
public function unserialize($serialized)
{
Expand Down Expand Up @@ -82,7 +78,6 @@ public function hasMorePages(): bool
return !$this->isDone() && $this->paginationToken !== null;
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
if (($pagination = $response->findRueckmeldung(Rueckmeldungscode::PAGINATION)) !== null) {
Expand All @@ -97,7 +92,6 @@ public function processResponse(Message $response)
}
}

/** {@inheritdoc} */
public function getNextRequest(?BPD $bpd, ?UPD $upd)
{
if ($this->requestSegments === null) {
Expand Down
1 change: 0 additions & 1 deletion lib/Fhp/Protocol/DialogInitialization.php
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,6 @@ public function __unserialize(array $serialized): void
parent::unserialize($parentSerialized);
}

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
throw new \AssertionError('DialogInitialization::createRequest should not be used.');
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Protocol/GetTanMedia.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ class GetTanMedia extends BaseAction
/** @var TanMediumListe[]|null */
private $tanMedia;

/** {@inheritdoc} */
protected function createRequest(BPD $bpd, ?UPD $upd)
{
// Prepare the HKTAB request.
Expand All @@ -32,7 +31,6 @@ protected function createRequest(BPD $bpd, ?UPD $upd)
}
}

/** {@inheritdoc} */
public function processResponse(Message $response)
{
parent::processResponse($response);
Expand Down
1 change: 0 additions & 1 deletion lib/Fhp/Segment/Common/Kik.php
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ class Kik extends BaseDeg
/** Max length: 30 (Mandatory/absent depending on the country) */
public ?string $kreditinstitutscode = null;

/** {@inheritdoc} */
public function validate()
{
parent::validate();
Expand Down
3 changes: 0 additions & 3 deletions lib/Fhp/Segment/Common/Kti.php
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ class Kti extends BaseDeg implements AccountInfo
public ?string $unterkontomerkmal = null;
public ?Kik $kreditinstitutskennung = null;

/** {@inheritdoc} */
public function validate()
{
parent::validate();
Expand Down Expand Up @@ -58,13 +57,11 @@ public static function fromAccount(SEPAAccount $account): Kti
return $result;
}

/** {@inheritdoc} */
public function getAccountNumber(): string
{
return $this->iban ?? $this->kontonummer;
}

/** {@inheritdoc} */
public function getBankIdentifier(): ?string
{
return $this->bic ?? $this->kreditinstitutskennung->kreditinstitutscode;
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Segment/Common/Kto.php
Original file line number Diff line number Diff line change
Expand Up @@ -31,13 +31,11 @@ public static function fromAccount(SEPAAccount $account): Kto
return static::create($account->getAccountNumber(), Kik::create($account->getBlz()));
}

/** {@inheritdoc} */
public function getAccountNumber(): string
{
return $this->kontonummer;
}

/** {@inheritdoc} */
public function getBankIdentifier(): ?string
{
return $this->kik->kreditinstitutscode;
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Segment/Common/KtvV3.php
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,11 @@ public static function fromAccount(SEPAAccount $account): KtvV3
return static::create($account->getAccountNumber(), $account->getSubAccount(), Kik::create($account->getBlz()));
}

/** {@inheritdoc} */
public function getAccountNumber(): string
{
return $this->kontonummer ?: '';
}

/** {@inheritdoc} */
public function getBankIdentifier(): ?string
{
return $this->kik->kreditinstitutscode;
Expand Down
2 changes: 0 additions & 2 deletions lib/Fhp/Segment/Common/Ktz.php
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,11 @@ class Ktz extends BaseDeg implements AccountInfo
public ?string $unterkontomerkmal = null;
public Kik $kreditinstitutskennung;

/** {@inheritdoc} */
public function getAccountNumber(): string
{
return $this->iban ?? $this->kontonummer;
}

/** {@inheritdoc} */
public function getBankIdentifier(): ?string
{
return $this->bic ?? $this->kreditinstitutskennung->kreditinstitutscode;
Expand Down
Loading