Migrate some core classes to PHP properties #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And fix a couple CS Fixer and IDE lint warnings. For `Statement` and `StatementOfAccount`, all properties have initializers, so there's no danger of reading them when they're not set. For `Transaction`, I verified that the only creator of instances of this class always populates all the fields.
Instead of failing with an obscure error because `curl_init()` returned false and we passed it on to `curl_setopt()`.
These objects are serialized over long periods of time, so the new property types must be compatible with what was there before. Several of the old field were effectively nullable, even when the `@var` annotation didn't reflect that.
Relatively straightforward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivated by some PHP CS Fixer and IDE warnings one some of those properties.
See individual commit properties for details.