[nemo-qml-plugin-contacts] Allow Person to be unresolved#74
Open
matthewvogt wants to merge 1 commit intonemomobile:masterfrom
Open
[nemo-qml-plugin-contacts] Allow Person to be unresolved#74matthewvogt wants to merge 1 commit intonemomobile:masterfrom
matthewvogt wants to merge 1 commit intonemomobile:masterfrom
Conversation
Contributor
|
LGTM, but has merge conflicts - drop or rebase, @matthewvogt? |
Contributor
Author
|
Correct resolution behaviour has not really been pinned down... I will rebase it. |
Revert to previous state, prior to resolving a match detail.
matthewvogt
force-pushed
the
phone-details
branch
from
6c79e46 to
03289e6
Compare
Contributor
|
LGTM from a code perspective (have not tested it). Feel free to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert to previous state, prior to resolving a match detail.