Skip to content

Thread safe Random class #560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shargon merged 2 commits into from
Feb 5, 2026
Merged

Thread safe Random class #560

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ac0bf40
Thread safe
shargon Feb 5, 2026
6c3f991
fix init
shargon Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/Neo.VM.Tests/Helpers/RandomHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,13 +10,15 @@
// modifications are permitted.

using System;
using System.Threading;

namespace Neo.Test.Helpers;

public class RandomHelper
{
private const string _randchars = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789";
private static readonly Random _rand = new();

private static readonly ThreadLocal<Random> _rand = new(() => new Random());

/// <summary>
/// Get random buffer
Expand All @@ -26,7 +28,7 @@ public class RandomHelper
public static byte[] RandBuffer(int length)
{
var buffer = new byte[length];
_rand.NextBytes(buffer);
_rand.Value.NextBytes(buffer);
return buffer;
}

Expand All @@ -41,7 +43,7 @@ public static string RandString(int length)

for (int i = 0; i < stringChars.Length; i++)
{
stringChars[i] = _randchars[_rand.Next(_randchars.Length)];
stringChars[i] = _randchars[_rand.Value.Next(_randchars.Length)];
}

return new string(stringChars);
Expand Down