NameService: minor improvements, part 3#26
Draft
AnnaShaleva wants to merge 3 commits intoneo-project:masterfrom
Draft
NameService: minor improvements, part 3#26AnnaShaleva wants to merge 3 commits intoneo-project:masterfrom
AnnaShaleva wants to merge 3 commits intoneo-project:masterfrom
Conversation
AnnaShaleva
force-pushed
the
nns-upd-3
branch
from
afcacfe to
27aa003
Compare
This was referenced Sep 9, 2022
Originally implemented in nspcc-dev/neofs-contract@14fc086.
And refactor GetRecords/GetAllRecords along the way, move commonly used code to a separate function. Originally introduced in nspcc-dev/neofs-contract@432c02a.
And move commonly used code to a separate methods. Originally introduced in nspcc-dev/neofs-contract@4b86891.
AnnaShaleva
force-pushed
the
nns-upd-3
branch
from
27aa003 to
3846bcc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The third part of NNS contract update, depends on #23 and #25, waiting for the first and second parts to be merged.
Includes: