Homepage fixes after Sebastians feedback #278
Conversation
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
src/css/doc.css
Outdated
| .doc a.external:hover::after { | ||
| top: -12px; | ||
| opacity: 0; | ||
| text-decoration: underline; |
There was a problem hiding this comment.
I would remove this. Links are already underlined, so adding this text-decoration just adds an underline to the arrow when hovering over an external link. (This change applies to all external links in the docs).
(I'm happy to make the other changes to external links, though.)
There was a problem hiding this comment.
This is because for some reason the arrow to the external link is disappearing when hovering
There was a problem hiding this comment.
Yeah, I don't really like that animation. The two lines that are deleted here I'm ok with that change. I just wouldn't add the text-decoration here.
src/css/doc.css
Outdated
| .doc .olist li, | ||
| .doc .ulist li { | ||
| margin-bottom: 0.5rem; | ||
| margin-bottom: 0; |
There was a problem hiding this comment.
This will change the appearance of all unordered lists in the docs. If we want to update the lists in the home page, or just the 'Keep exploring' card, we should create a more specific rule that applies to those link - a rule for something like body.docs-ndl .ulist li... or body.docs-ndl div.lists .ulist li... in docs-ndl.css
There was a problem hiding this comment.
I think the Keep exploring card is barely being used and the places where it still exists need to be updated, but if this affects the content in the doc pages in a disruptive way, then yes. Do you think that is the case?
There was a problem hiding this comment.
Yes, this would apply to any page generated from the UI bundle because we wrap the page contents in <article class="doc">...</article>
There was a problem hiding this comment.
Do you think a 0.5rem difference could be disruptive to the rest of the docs? If so, then it's better to create a new rule like you suggested
There was a problem hiding this comment.
I think it makes list items more readable when the content wraps onto multiple lines. Without it, the spacing between the lines of a list item and the spacing between two list items are pretty much the same. The effect is similar to what would happen if there was no margin below a paragraph.
There was a problem hiding this comment.
Ok, so I will fix it as you suggested!
2 participants
No description provided.