Skip to content

Making all card styles clickable #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 5, 2025
Merged

Making all card styles clickable #298

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c134d7b
Making all card styles clickable
lidiazuin Feb 27, 2025
7103bd8
remove unrelated file
lidiazuin Feb 27, 2025
70d2088
adding link class for homepage
lidiazuin Mar 5, 2025
0894948
update after review
lidiazuin Mar 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion preview-src/docs-ndl.adoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ Learn more about graph databases and start working with your data using Neo4j to
xref:tutorials:index.adoc[Get started]
--

[.cards.selectable]
[.cards]
== CTA cards

[role=label--featured]
Expand Down
1 change: 1 addition & 0 deletions src/css/docs-ndl.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -651,6 +651,7 @@ body.docs-ndl .lists .sect2 {
line-height: 2rem;
}

body.docs-ndl .cards .sect2:hover,
Copy link
Collaborator Author

@lidiazuin lidiazuin Feb 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@recrwplay I only managed to fix the hover effect, but not the a state to make [.cards] without .selectable or .not-selectable to become clickable. Could you help me, please? :))

Copy link
Collaborator

@recrwplay recrwplay Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cards can be displayed in two ways:

  • Selectable - the first link in [.links] on this card is wrapped round the card contents. The whole card becomes a link. No links are displayed on the card
  • All other cards - The card itself is not selectable. The links in [.links] are displayed on the card.

A card becomes selectable if it has [.selectable] applied, or if it's in a section that has that role.

It sounds like you want to make all cards clickable, including cards that display a link. What happens when there is more than one link on a card?

body.docs-ndl .cards.selectable .sect2:hover,
body.docs-ndl .cards .sect2.selectable:hover {
transition: 0.1s linear;
Expand Down
Loading