Fix canonicals (finally) #300
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for neo4j-docs-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This was referenced Mar 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires pre-release versions to be marked as prerelease so Antora doesn't consider them as 'latest'.
Pre-release versions will be included in the version selector, unless
page-nav-selectors-hide-prereleaseis set to true.This PR also modifies
page.canonicalUrl. After it is set by Antora, a helper in the ui-bundle checks the value, and if it contains the version name that is the latest version of the page's component, the url is updated by replacing the version name with 'current'. This ensures that all our canonicals point to current (except where there is no equivalent of a page in the latest release. In that case the canonical is self-referencing).