Skip to content

allow anchor click propagation from nav #301

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

allow anchor click propagation from nav #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/js/01-nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,6 @@

if (navContainer && navToggle) {
navToggle && navToggle.addEventListener('click', showNav)
// NOTE don't let click events propagate outside of nav container
navContainer && navContainer.addEventListener('click', concealEvent)

var menuPanel = navContainer.querySelector('[data-panel=menu]')
if (!menuPanel) return
Expand All @@ -27,6 +25,8 @@
find(menuPanel, '.nav-item-toggle:not(a)').forEach(function (btn) {
var li = btn.parentElement
btn.addEventListener('click', toggleActive.bind(li))
// don't let toggle clicks propagate
btn.addEventListener('click', concealEvent)
var navItemSpan = findNextElement(btn, '.nav-text')
if (navItemSpan) {
navItemSpan.style.cursor = 'pointer'
Expand Down