Skip to content

Fix google analytics bug #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2025
+7 −5
Merged

Fix google analytics bug #344

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
049fdab
remove unused vars
recrwplay Oct 28, 2025
e6a31f8
remove unused vars and ga event on version selector
recrwplay Oct 28, 2025
9aff8bc
reword comment
recrwplay Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions src/js/01-nav.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,14 +57,16 @@
versionSelector.addEventListener('change', function (e) {
const target = e.target

const current = target.dataset.current
const next = target.selectedOptions[0].dataset.version
// const current = target.dataset.current
// const next = target.selectedOptions[0].dataset.version

const url = target.value

if (window.ga) {
window.ga('send', 'event', 'version-select', 'From: ' + current + ';To:' + next + ';')
}
// temporarily disable analytics for selector-versions
// because it is now broken
// if (window.ga) {
// window.ga('send', 'event', 'version-select', 'From: ' + current + ';To:' + next + ';')
// }

document.location.assign(url)
})
Expand Down