Skip to content

Fixed booleans for parameter select (#953) #1020

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Fixed booleans for parameter select (#953) #1020

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/chart/parameter/component/NodePropertyParameterSelect.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ const NodePropertyParameterSelectComponent = (props: ParameterSelectProps) => {
newValue.push(RenderSubValue(val));
}
} else if (!isMulti) {
newValue = extraRecords.filter((r) => (r?._fields?.[displayValueRowIndex]?.toString() || null) == newDisplay)[0]
// if records are toStringed before comparison, toString the comparing variable
const newDisplay2 = typeof newDisplay === 'boolean' ? newDisplay.toString() : newDisplay;
newValue = extraRecords.filter((r) => (r?._fields?.[displayValueRowIndex]?.toString() || null) == newDisplay2)[0]
._fields[realValueRowIndex];

newValue =
Expand Down Expand Up @@ -165,8 +167,13 @@ const NodePropertyParameterSelectComponent = (props: ParameterSelectProps) => {
/>
);
}
let options = extraRecords?.map((r) => r?._fields?.[displayValueRowIndex] || '(no data)');

// "false" will not be mapped to "(no data)"
let options = extraRecords
?.map((r) => r?._fields?.[displayValueRowIndex])
.map((f) => (f === undefined || f === null ? '(no data)' : f));
options = props.autoSort ? options.sort() : options;

return (
<div className={'n-flex n-flex-row n-flex-wrap n-items-center'}>
<Autocomplete
Expand Down
Loading