Skip to content

Current Users or ALL Users getting deleted in an Update #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Current Users or ALL Users getting deleted in an Update #906

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e1096de
fixed: when updating a user permission by DELETING a user from a cert…
AleSim94 Jun 11, 2024
d5c6182
updated the code so that if datbase selected is empty we show feedbac…
AleSim94 Jul 9, 2024
344fb8e
Merge branch 'develop' into fix/rbac_existing_users_deleted_bug
nielsdejong Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/extensions/rbac/RBACManagementModal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,6 @@ export const RBACManagementModal = ({ open, handleClose, currentRole, createNoti

const handleSave = async () => {
createNotification('Updating', `Access for role '${currentRole}' is being updated, please wait...`);
console.log(selectedUsers);
updateUsers(
driver,
currentRole,
Expand Down
46 changes: 24 additions & 22 deletions src/extensions/rbac/RBACUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,34 +265,36 @@ export async function updateUsers(driver, currentRole, allUsers, selectedUsers,
`REVOKE ROLE ${currentRole} FROM ${escapedAllUsers}`,
{},
1000,
(status) => {
async (status) => {
globalStatus = status;
if (globalStatus == QueryStatus.NO_DATA || globalStatus == QueryStatus.COMPLETE) {
// TODO: Neo4j is very slow in updating after the previous query, even though it is technically a finished query.
// We build in an artificial delay... This must be improved the future.
setTimeout(async () => {
if (selectedUsers.length > 0) {
const escapedSelectedUsers = selectedUsers.map((user) => `\`${user}\``).join(',');
await runCypherQuery(
driver,
'system',
`GRANT ROLE ${currentRole} TO ${escapedSelectedUsers};`,
{},
1000,
(status) => {
if (status == QueryStatus.NO_DATA || QueryStatus.COMPLETE) {
onSuccess();
}
}
);
} else {
onSuccess();
}
}, 2000);
}
},
(records) => {
if (records && records[0] && records[0].error) {
onFail(records[0].error);
}
}
);
if (globalStatus == QueryStatus.NO_DATA || globalStatus == QueryStatus.COMPLETE) {
// TODO: Neo4j is very slow in updating after the previous query, even though it is technically a finished query.
// We build in an artificial delay...
if (selectedUsers.length > 0) {
const escapedSelectedUsers = selectedUsers.map((user) => `\`${user}\``).join(',');
await runCypherQuery(
driver,
'system',
`GRANT ROLE ${currentRole} TO ${escapedSelectedUsers}`,
{},
1000,
(status) => {
if (status == QueryStatus.NO_DATA || QueryStatus.COMPLETE) {
onSuccess();
}
}
);
} else {
onSuccess();
}
}
}