test: Add test for Client

Author: exaby73

src/Bolt/BoltDriver.php

@@ -15,7 +15,6 @@
 
 use Exception;
 
-use Psr\Log\LogLevel;
 use function is_string;
 
 use Laudis\Neo4j\Authentication\Authenticate;
@@ -29,7 +28,7 @@
 use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\Formatter\OGMFormatter;
 use Psr\Http\Message\UriInterface;
-use Throwable;
+use Psr\Log\LogLevel;
 
 /**
  * Drives a singular bolt connections.
@@ -105,7 +104,8 @@ public function verifyConnectivity(?SessionConfiguration $config = null): bool
         try {
             GeneratorHelper::getReturnFromGenerator($this->pool->acquire($config));
         } catch (ConnectException $e) {
-            $this->pool->getLogger()->log(LogLevel::WARNING, 'Could not connect to server on URI ' . $this->parsedUrl->__toString(), ['error' => $e]);
+            $this->pool->getLogger()->log(LogLevel::WARNING, 'Could not connect to server on URI '.$this->parsedUrl->__toString(), ['error' => $e]);
+
             return false;
         }
 

src/Common/DriverSetupManager.php

@@ -13,12 +13,11 @@
 
 namespace Laudis\Neo4j\Common;
 
-use Bolt\error\ConnectException;
-use Psr\Log\LogLevel;
 use function array_key_exists;
 use function array_key_first;
 use function array_reduce;
 
+use Bolt\error\ConnectException;
 use Countable;
 use InvalidArgumentException;
 use Laudis\Neo4j\Authentication\Authenticate;
@@ -31,6 +30,7 @@
 
 use const PHP_INT_MIN;
 
+use Psr\Log\LogLevel;
 use RuntimeException;
 use SplPriorityQueue;
 
@@ -152,6 +152,7 @@ public function verifyConnectivity(SessionConfiguration $config, ?string $alias
                 sprintf('Could not connect to server using alias (%s)', $alias ?? '<default>'),
                 ['exception' => $e]
             );
+
             return false;
         }
 

src/Neo4j/Neo4jDriver.php

@@ -16,7 +16,6 @@
 use Bolt\error\ConnectException;
 use Exception;
 
-use Psr\Log\LogLevel;
 use function is_string;
 
 use Laudis\Neo4j\Authentication\Authenticate;
@@ -33,6 +32,7 @@
 use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\Formatter\OGMFormatter;
 use Psr\Http\Message\UriInterface;
+use Psr\Log\LogLevel;
 
 /**
  * Driver for auto client-side routing.
@@ -107,7 +107,7 @@ public function verifyConnectivity(?SessionConfiguration $config = null): bool
         try {
             GeneratorHelper::getReturnFromGenerator($this->pool->acquire($config));
         } catch (ConnectException $e) {
-            $this->pool->getLogger()->log(LogLevel::WARNING, 'Could not connect to server on URI ' . $this->parsedUrl->__toString(), ['error' => $e]);
+            $this->pool->getLogger()->log(LogLevel::WARNING, 'Could not connect to server on URI '.$this->parsedUrl->__toString(), ['error' => $e]);
 
             return false;
         }

tests/Integration/ClientIntegrationTest.php

@@ -19,13 +19,17 @@
 use Laudis\Neo4j\Bolt\BoltDriver;
 use Laudis\Neo4j\Bolt\ConnectionPool;
 use Laudis\Neo4j\ClientBuilder;
+use Laudis\Neo4j\Common\DriverSetupManager;
 use Laudis\Neo4j\Common\Uri;
 use Laudis\Neo4j\Contracts\DriverInterface;
 use Laudis\Neo4j\Contracts\TransactionInterface;
 use Laudis\Neo4j\Databags\DriverConfiguration;
+use Laudis\Neo4j\Databags\DriverSetup;
 use Laudis\Neo4j\Databags\SessionConfiguration;
 use Laudis\Neo4j\Databags\Statement;
+use Laudis\Neo4j\Databags\TransactionConfiguration;
 use Laudis\Neo4j\Exception\Neo4jException;
+use Laudis\Neo4j\Formatter\SummarizedResultFormatter;
 use Laudis\Neo4j\Tests\EnvironmentAwareIntegrationTest;
 use Psr\Log\LoggerInterface;
 use Psr\Log\LogLevel;
@@ -61,6 +65,45 @@ public function testDriverAuthFailureVerifyConnectivity(): void
         $driver->verifyConnectivity();
     }
 
+    public function testClientAuthFailureVerifyConnectivity(): void
+    {
+        $connection = $_ENV['CONNECTION'] ?? false;
+        if (str_starts_with($connection, 'http')) {
+            $this->markTestSkipped('HTTP does not support auth failure connectivity passing');
+        }
+
+        if (!is_string($connection)) {
+            $connection = 'bolt://localhost';
+        }
+
+        $uri = Uri::create($connection);
+        $uri = $uri->withUserInfo('neo4j', 'absolutelyonehundredpercentawrongpassword');
+
+        /** @noinspection PhpUnhandledExceptionInspection */
+        $conf = DriverConfiguration::default()->withLogger(LogLevel::DEBUG, $this->createMock(LoggerInterface::class));
+        $logger = $conf->getLogger();
+        if ($logger === null) {
+            throw new RuntimeException('Logger not set');
+        }
+
+        $client = (new ClientBuilder(
+            SessionConfiguration::create(),
+            TransactionConfiguration::create(),
+            (new DriverSetupManager(
+                SummarizedResultFormatter::create(),
+                $conf,
+            ))->withSetup(
+                new DriverSetup($uri, Authenticate::fromUrl($uri, $logger))
+            )
+        ))->build();
+
+        $driver = $client->getDriver(null);
+
+        $this->expectException(Neo4jException::class);
+        $this->expectExceptionMessage('Neo4j errors detected. First one with code "Neo.ClientError.Security.Unauthorized" and message "The client is unauthorized due to authentication failure."');
+        $driver->verifyConnectivity();
+    }
+
     public function testDifferentAuth(): void
     {
         $auth = Authenticate::fromUrl($this->getUri());