chore: Cleanup merge artifacts from OGM formatter and HTTP removal PRs #246
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the OGM formatter PR in it's entirety did not get merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason, some files that were deleted in the OGMFormatter removal PR (#245) namely the deprecated formatters were not deleted after merging the HTTP removal PR. This might have been due to the stacked nature of the PR and changes that were done in those formatters removing HTTP logic that Git prioritised over deleting those files in the other PR.
Along with that, the README changes were also not reflected so that has been moved over to this PR as well. I also took the opportunity to fix a typo @stefanak-michal pointed out in https://github.com/neo4j-php/neo4j-php-client/pull/245/files#r1928493904