refactor: Add bolt message objects #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PHP CS Fixer still has an issue described in #247 (comment). Once we come to a conclusion on that and merge that PR in, we should merge main into this one and that CI should pass |
transistive
requested changes
Feb 13, 2025
…lasses (#254) * Extracted HELLO, LOGON, and LOGOFF message creation into dedicated classes - Updated BasicAuth, KerberosAuth, NoAuth, and OpenIDConnectAuth to utilize new message classes - Added unit tests for each message class and authentication strategy * Fixed cluster tests --------- Co-authored-by: pratikshazalte69 <[email protected]>
|
Thanks @p123-stack for the Authentication related messages 🙌 |
transistive
approved these changes
May 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add an abstraction over the bolt messages.
It adds classes for individual messages and a factory for easily creating them.