winp

Author: Pratiksha

src/Configuration.php

@@ -26,7 +26,6 @@ public function __construct(
         public readonly Bookmarks  $bookmarks = new Bookmarks([]),
         public readonly AccessMode $accessMode = AccessMode::WRITE,
     ) {
-        // Validate that baseUri is not empty
         if (empty($this->baseUri)) {
             throw new InvalidArgumentException("Address (baseUri) must be provided.");
         }

src/Neo4jQueryAPI.php

@@ -23,13 +23,13 @@ public function __construct(
         private Neo4jRequestFactory $requestFactory,
         ?Configuration $config = null
     ) {
-        $this->config = $config ?? new Configuration(getenv("NEO4J_ADDRESS")); // Default configuration if not provided
+        $this->config = $config ?? new Configuration(baseUri: 'http://myaddress'); // Default configuration if not provided
     }
 
     /**
      * @api
      */
-    public static function login(string $address, ?AuthenticateInterface $auth = null, ?Configuration $config = null): self
+    public static function login(string $address = null, ?AuthenticateInterface $auth = null, ?Configuration $config = null): self
     {
         $client = new Client();
         $config = $config ?? new Configuration(baseUri: $address);

tests/Integration/Neo4jQueryAPITest.php

@@ -36,9 +36,23 @@ public function testLoginWithEmptyAddress()
 
         Neo4jQueryAPI::login('http://myaddress', Authentication::fromEnvironment(), $config);
     }
-    /**
-     * Test to ensure that an exception is thrown when baseUri is empty.
-     */
+    public function testLoginWithNullConfiguration()
+    {
+        $config = null;
+
+        $api = Neo4jQueryAPI::login('http://myaddress', Authentication::fromEnvironment(), $config);
+
+        $this->assertInstanceOf(Neo4jQueryAPI::class, $api);$this->assertEquals('http://myaddress', $api->getConfig()->baseUri);
+    }
+    public function testConfigOnly()
+    {
+        $config = new COnfiguration(baseUri: 'http://valid.address');
+
+        $api = Neo4jQueryAPI::login(auth: Authentication::fromEnvironment(), config: $config);
+
+        $this->assertInstanceOf(Neo4jQueryAPI::class, $api);
+        $this->assertEquals('http://valid.address', $api->getConfig()->baseUri);
+    }
 
 
 }