psalm applied #8
Conversation
There was a problem hiding this comment.
Good work!
Small remarks: if most of the methods need to be marked with @api, it is probably worth it to mark the class as @api instead of every method.
Also, before I can merge this PR you have to resolve the conflicts.
The easiest way is to merge main into this branch and resolve the conflicts using the tool in phpstorm
composer.json
Outdated
| "ext-json": "*", | ||
| "php": "^8.1" | ||
| "php": "^8.1", | ||
| "symfony/finder": "^7.2" |
There was a problem hiding this comment.
this should be a development dependency, if we even need it.
| * @api | ||
| */ | ||
|
|
||
| public function getType(): ?string |
There was a problem hiding this comment.
we should look into declaring the class as part of the api instead of all the methods, what do you think?
| // $username = 'neo4j'; | ||
| // $password = '9lWmptqBgxBOz8NVcTJjgs3cHPyYmsy63ui6Spmw1d0'; | ||
| //// $connectionUrl = 'https://6f72daa1.databases.neo4j.io/db/neo4j/query/v2'; | ||
|
|
There was a problem hiding this comment.
This definitely should be removed!
| /** | ||
| * @template TKey of array-key | ||
| * @template TValue | ||
| * @implements IteratorAggregate<TKey, TValue> |
There was a problem hiding this comment.
Great stuff! Glad you werre able to figure this one out
2 participants
psalm errors are solved