Conversation
SiddheshBhatkar777
force-pushed
the
neo4j-symfony-fix-readme
branch
from
43c9728 to
d9e9f3f
Compare
SiddheshBhatkar777
force-pushed
the
neo4j-symfony-fix-readme
branch
from
d9e9f3f to
3960eb4
Compare
| [installation chapter](https://getcomposer.org/doc/00-intro.md) | ||
| of the Composer documentation. | ||
|
|
||
| Applications that don't use Symfony Flex |
There was a problem hiding this comment.
This should stay. If it uses Symfony Flex the configuration will already be in place
There was a problem hiding this comment.
Thank you for highlighting the same, I have added it back.
docs/README.md
Outdated
| $ docker-compose up -d | ||
| ``` | ||
|
|
||
| This will start a Neo4j instance accessible at `bolt://neo4j:testtest@neo4j:7687`. |
There was a problem hiding this comment.
Make it clear that, by default, the server is accessible only at this address when using the PHP Docker container defined in the Docker Compose file.
There was a problem hiding this comment.
I have modified the message made it clear that by default, the server is accessible only at this address when using the PHP Docker container defined in the Docker Compose file.
src/Collector/Neo4jDataCollector.php
Outdated
| } | ||
|
|
||
| if (isset($summary['result']) && method_exists($summary['result'], 'getStatement')) { | ||
| /** @var object $result */ |
There was a problem hiding this comment.
Please rever these changes unless something is broken here
There was a problem hiding this comment.
I have reverted these changes.
tests/App/config/default.yml
Outdated
| secret: test | ||
| test: true | ||
| profiler: { enabled: true, collect: true } | ||
| profiler: { enabled: true, collect: true, collect_serializer_data: true } |
There was a problem hiding this comment.
This pr should not have new configuration changes. It is out of scope
There was a problem hiding this comment.
I have reverted this change.
SiddheshBhatkar777
force-pushed
the
neo4j-symfony-fix-readme
branch
8 times, most recently
from
e4e179f to
f49b9e0
Compare
SiddheshBhatkar777
force-pushed
the
neo4j-symfony-fix-readme
branch
from
f49b9e0 to
28e068c
Compare
SiddheshBhatkar777
changed the title
SiddheshBhatkar777
changed the title
2 participants
Adds documentation for code quality tools available in the project.
Changes:
Add Code Quality section to README.md
Document composer check-cs command for checking code style
Document composer fix-cs command for fixing code style issues
Document composer psalm command for running static analysis