Update MATCH page #1080

JPryce-Aklundh · 2024-10-24T13:44:01Z

No description provided.

gem-neo4j

Very nice :D

gem-neo4j · 2024-10-24T14:06:31Z

modules/ROOT/pages/clauses/match.adoc

+----
+<1> The `Person` and `Movie` nodes matched in this step are stored in variables.
+which are then passed on to the second row of the query.
+<2> The `movie` variable is here implicitly imported by its occurrence in the `count()` function.


Suggested change

<2> The `movie` variable is here implicitly imported by its occurrence in the `count()` function.

<2> The `movies` variable here is implicitly imported by its occurrence in the `count()` function.

gem-neo4j · 2024-10-24T14:07:37Z

modules/ROOT/pages/clauses/match.adoc

+<2> The `movie` variable is here implicitly imported by its occurrence in the `count()` function.
+The `WITH` clause explicitly imports the `actors` variable.
+<3> An xref:clauses/order-by.adoc[`ORDER BY`]  clause orders the results by `movieCount` in descending order, ensuring that the `Person` with the highest number of movies appears at the top, and xref:clauses/limit.adoc[`LIMIT] 1` ensures that all other `Person` nodes are discarded.
+<4> The second MATCH clause finds all `Movie` nodes associated with the `Person` nodes currently bound to the `actors` variable.


Suggested change

<4> The second MATCH clause finds all `Movie` nodes associated with the `Person` nodes currently bound to the `actors` variable.

<4> The second `MATCH` clause finds all `Movie` nodes associated with the `Person` nodes currently bound to the `actors` variable.

rsill-neo4j · 2024-10-25T10:16:46Z

modules/ROOT/pages/clauses/match.adoc

-[[match-on-multiple-rel-types]]
-=== Match on multiple relationship types
+[[match-on-multiple-relationship-types]]
+=== Filter on multiple relationship types


for nodes, the new heading is "MATCH using label expressions"
makes me wonder if the two could be unified, "MATCH using node label expressions" and "MATCH using relationship label expressions" or something similar

Yep - will do relationship type expressions

rsill-neo4j · 2024-10-25T10:17:36Z

modules/ROOT/pages/clauses/match.adoc

+
+For more information about how to set parameters, see xref:syntax/parameters.adoc[Syntax -> Parameters].

-For example, the following query creates a relationship which contains a space (`OLD FRIENDS`) between `Martin Sheen` and `Rob Reiner`.


the "OLD FRIENDS" example got dropped completely, is this intentional?

Yeah - it's pretty niche and seemed better suited the CREATE page if anything.

rsill-neo4j · 2024-10-25T10:21:31Z

modules/ROOT/pages/clauses/match.adoc

+2+|Rows: 1
 |===

+For a full list of all label expressions supported by Cypher, see xref:patterns/reference.adoc#label-expressions[Patterns -> Label expressions].


Suggested change

For a full list of all label expressions supported by Cypher, see xref:patterns/reference.adoc#label-expressions[Patterns -> Label expressions].

For a full list of label expressions supported by Cypher, see xref:patterns/reference.adoc#label-expressions[Patterns -> Label expressions].

alternatively, "-full"

rsill-neo4j · 2024-10-25T10:34:35Z

modules/ROOT/pages/clauses/match.adoc


-It is possible to match on multiple relationship types by using the pipe symbol (`|`).
-For example:
+It is possible to match for a pattern containing one out of several relationship types using the `OR` symbol, `|`.


Suggested change

It is possible to match for a pattern containing one out of several relationship types using the `OR` symbol, `|`.

It is possible to match a pattern containing one of several relationship types using the `OR` symbol, `|`.

rsill-neo4j · 2024-10-25T10:38:16Z

modules/ROOT/pages/clauses/match.adoc

+[[where-predicates]]
+== MATCH with WHERE predicates
+
+The `MATCH` clause is often paired with a `WHERE` sub-clause, which adds predicates to refine the patterns, making them more specific.


on "sub-clause" - a quick look at the source files of the cypher manual reveals that we're not using "sub-clause" or "subclause" consistently (15x in 5 files for sub-clause, 7x in 7 files for subclause).

i guess it is sub-clause - but we should follow up with changing the occurrences of ""subclause".

Ok, we can do that.

rsill-neo4j · 2024-10-25T10:48:31Z

modules/ROOT/pages/clauses/match.adoc

+
+A variable can be implicitly carried over to the following clause by being referenced in another operation.
+A variable can also be explicitly passed to the following clause using the xref:clauses/with.adoc[`WITH`] clause.
+If a variable is neither implicitly nor explicitly carried over to its following clause, it will be discarded and unavailable for reference later in the query.


Suggested change

If a variable is neither implicitly nor explicitly carried over to its following clause, it will be discarded and unavailable for reference later in the query.

If a variable is neither implicitly nor explicitly carried over to its following clause, it will be discarded and is not available for reference later in the query.

rsill-neo4j · 2024-10-25T10:49:54Z

modules/ROOT/pages/clauses/match.adoc

+<1> The `Person` and `Movie` nodes matched in this step are stored in variables.
+which are then passed on to the second row of the query.


Suggested change

<1> The `Person` and `Movie` nodes matched in this step are stored in variables.

which are then passed on to the second row of the query.

<1> The `Person` and `Movie` nodes matched in this step are stored in variables, which are then passed on to the second row of the query.

rsill-neo4j · 2024-10-25T10:50:46Z

modules/ROOT/pages/clauses/match.adoc

+----
+<1> The `Person` and `Movie` nodes matched in this step are stored in variables.
+which are then passed on to the second row of the query.
+<2> The `movies` variable is here implicitly imported by its occurrence in the `count()` function.


Suggested change

<2> The `movies` variable is here implicitly imported by its occurrence in the `count()` function.

<2> The `movies` variable is implicitly imported by its occurrence in the `count()` function.

rsill-neo4j · 2024-10-25T10:51:15Z

modules/ROOT/pages/clauses/match.adoc

+which are then passed on to the second row of the query.
+<2> The `movies` variable is here implicitly imported by its occurrence in the `count()` function.
+The `WITH` clause explicitly imports the `actors` variable.
+<3> An xref:clauses/order-by.adoc[`ORDER BY`]  clause orders the results by `movieCount` in descending order, ensuring that the `Person` with the highest number of movies appears at the top, and xref:clauses/limit.adoc[`LIMIT] 1` ensures that all other `Person` nodes are discarded.


Suggested change

<3> An xref:clauses/order-by.adoc[`ORDER BY`] clause orders the results by `movieCount` in descending order, ensuring that the `Person` with the highest number of movies appears at the top, and xref:clauses/limit.adoc[`LIMIT] 1` ensures that all other `Person` nodes are discarded.

<3> An xref:clauses/order-by.adoc[`ORDER BY`] clause orders the results by `movieCount` in descending order, ensuring that the `Person` with the highest number of movies appears at the top, and xref:clauses/limit.adoc[`LIMIT] 1` ensures that all other `Person` nodes are discarded.

rsill-neo4j · 2024-10-25T10:54:19Z

modules/ROOT/pages/clauses/match.adoc

-However, there are cases where you can influence the decisions taken by the query compiler.
-Read more about indexes in xref:indexes/search-performance-indexes/managing-indexes.adoc[], and more about specifying hints to force Neo4j to solve a query in a specific way in xref::indexes/search-performance-indexes/index-hints.adoc[Planner hints and the USING keyword].
-
+The `MATCH` clause enables you to define specific patterns that the database will search for within its graph structure.


general note about "will" - i think there's a style guide rule to avoid it where possible. there are many occurrences in this page, but i can also see them being warranted because a query happens at a certain point in time and then the database operations described happen later. i guess it comes down to personal preference :)

I will keep it for now :)

rsill-neo4j

one more suggestion + approval

rsill-neo4j · 2024-10-25T11:48:22Z

modules/ROOT/pages/clauses/match.adoc

-For example:
+In Cypher, the behavior of a query is defined by its clauses.
+Each clause takes the current graph state and a table of intermediate results, processes them, and passes the updated graph state and results to the next clause.
+The first clause starts with the graph's initial state and an empty table, while the final clause produces the query's result.


Suggested change

The first clause starts with the graph's initial state and an empty table, while the final clause produces the query's result.

The first clause starts with the graph's initial state and an empty table, while the final clause produces the query result.

neo-technology-commit-status-publisher · 2024-10-25T11:54:05Z

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

JPryce-Aklundh added 3 commits October 22, 2024 09:18

more

26208b5

fixä

5c4df40

more updates

2991f8e

JPryce-Aklundh added cherry-pick-this-to-4.4 Cherry pick this PR changes to the 4.4 branch cherry-pick-this-to-5.x Cherry pick this PR changes to the 5.x branch auto-cherry-pick-to-cypher-25 labels Oct 24, 2024

remove father_of rel

d20213e

JPryce-Aklundh assigned rsill-neo4j Oct 24, 2024

gem-neo4j approved these changes Oct 24, 2024

View reviewed changes

JPryce-Aklundh added 2 commits October 24, 2024 21:53

corrections

db449c1

more corrections

6926d2c

rsill-neo4j reviewed Oct 25, 2024

View reviewed changes

JPryce-Aklundh added 2 commits October 25, 2024 13:20

editorial fixes

8fed76e

fix table formatting

3e0207b

rsill-neo4j approved these changes Oct 25, 2024

View reviewed changes

JPryce-Aklundh added 2 commits October 25, 2024 13:50

final

036cb11

Merge branch 'dev' into match-update

eb2a5db

JPryce-Aklundh removed the cherry-pick-this-to-4.4 Cherry pick this PR changes to the 4.4 branch label Oct 25, 2024

JPryce-Aklundh merged commit ea86dc9 into neo4j:dev Oct 25, 2024
5 checks passed

JPryce-Aklundh deleted the match-update branch October 25, 2024 12:22

JPryce-Aklundh added a commit that referenced this pull request Oct 25, 2024

Update MATCH page (#1080)

518011e

JPryce-Aklundh added a commit that referenced this pull request Oct 25, 2024

Update MATCH page (#1080)

ba96a72

	<2> The `movie` variable is here implicitly imported by its occurrence in the `count()` function.
	<2> The `movies` variable here is implicitly imported by its occurrence in the `count()` function.

	<4> The second MATCH clause finds all `Movie` nodes associated with the `Person` nodes currently bound to the `actors` variable.
	<4> The second `MATCH` clause finds all `Movie` nodes associated with the `Person` nodes currently bound to the `actors` variable.


		For more information about how to set parameters, see xref:syntax/parameters.adoc[Syntax -> Parameters].

		For example, the following query creates a relationship which contains a space (`OLD FRIENDS`) between `Martin Sheen` and `Rob Reiner`.

	For a full list of all label expressions supported by Cypher, see xref:patterns/reference.adoc#label-expressions[Patterns -> Label expressions].
	For a full list of label expressions supported by Cypher, see xref:patterns/reference.adoc#label-expressions[Patterns -> Label expressions].

	It is possible to match for a pattern containing one out of several relationship types using the `OR` symbol, `\|`.
	It is possible to match a pattern containing one of several relationship types using the `OR` symbol, `\|`.

	If a variable is neither implicitly nor explicitly carried over to its following clause, it will be discarded and unavailable for reference later in the query.
	If a variable is neither implicitly nor explicitly carried over to its following clause, it will be discarded and is not available for reference later in the query.

		<1> The `Person` and `Movie` nodes matched in this step are stored in variables.
		which are then passed on to the second row of the query.

	<2> The `movies` variable is here implicitly imported by its occurrence in the `count()` function.
	<2> The `movies` variable is implicitly imported by its occurrence in the `count()` function.

	<3> An xref:clauses/order-by.adoc[`ORDER BY`] clause orders the results by `movieCount` in descending order, ensuring that the `Person` with the highest number of movies appears at the top, and xref:clauses/limit.adoc[`LIMIT] 1` ensures that all other `Person` nodes are discarded.
	<3> An xref:clauses/order-by.adoc[`ORDER BY`] clause orders the results by `movieCount` in descending order, ensuring that the `Person` with the highest number of movies appears at the top, and xref:clauses/limit.adoc[`LIMIT] 1` ensures that all other `Person` nodes are discarded.

	The first clause starts with the graph's initial state and an empty table, while the final clause produces the query's result.
	The first clause starts with the graph's initial state and an empty table, while the final clause produces the query result.

Update MATCH page #1080

Update MATCH page #1080

Uh oh!

Conversation

JPryce-Aklundh commented Oct 24, 2024

Uh oh!

gem-neo4j left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rsill-neo4j left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

neo-technology-commit-status-publisher commented Oct 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

neo-technology-commit-status-publisher commented Oct 25, 2024 •

edited

Loading