Explain return values from vector functions #1104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JPryce-Aklundh
added
cherry-pick-this-to-5.x
parnmatt
approved these changes
Nov 11, 2024
Contributor
parnmatt
left a comment
parnmatt
left a comment
There was a problem hiding this comment.
Looks reasonable, just suggesting being consistent with the numbers being in backticks
| | Both vectors must be {link-vector-indexes}#indexes-vector-similarity-cosine[*valid*] with respect to cosine similarity. | ||
| | The implementation is identical to that of the latest available vector index provider (`vector-2.0`). | ||
| | `vector.similarity.cosine()` returns the neighborhood of nodes along with their respective cosine similarity scores, sorted in descending order of similarity. | ||
| The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector. |
Contributor
There was a problem hiding this comment.
Suggested change
| The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector. | |
| The similarity score range from `0` and `1`, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector. |
| | Both vectors must be {link-vector-indexes}#indexes-vector-similarity-euclidean[*valid*] with respect to Euclidean similarity. | ||
| | The implementation is identical to that of the latest available vector index provider (`vector-2.0`). | ||
| | `vector.similarity.euclidean()` returns the neighborhood of nodes along with their respective Euclidean similarity scores, sorted in descending order of similarity. | ||
| The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector. |
Contributor
There was a problem hiding this comment.
Suggested change
| The similarity score range from `0` and 1, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector. | |
| The similarity score range from `0` and `1`, with scores closer to `1` indicating a higher degree of similarity between the indexed vector and the query vector. |
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
JPryce-Aklundh
added a commit
that referenced
this pull request
Nov 11, 2024
JPryce-Aklundh
added a commit
that referenced
this pull request
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.