graph references in Cypher 25 #1295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hunterness
reviewed
Jun 2, 2025
ConorNeo
approved these changes
Jun 4, 2025
Hunterness
reviewed
Jun 5, 2025
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
Comment on lines
182
to
184
| In Cypher 5, there was some special logic for composite databases or constituents with dots, | ||
| which required quotes around those name parts in order to find the name. This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. In Cypher 25 the graph references can be passed in without quoting | ||
| as in the name column from `SHOW ALIASES FOR DATABASE`.Note that escaping graph names within the graph functions string argument is not supported in Cypher 5. |
There was a problem hiding this comment.
Suggested change
| In Cypher 5, there was some special logic for composite databases or constituents with dots, | |
| which required quotes around those name parts in order to find the name. This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. In Cypher 25 the graph references can be passed in without quoting | |
| as in the name column from `SHOW ALIASES FOR DATABASE`.Note that escaping graph names within the graph functions string argument is not supported in Cypher 5. | |
| In Cypher 5, there was some special logic for composite databases or constituents with dots, which required quotes around those name parts in order to find the name. | |
| This deprecations apply to xref::values-and-types/graph-references.adoc[Graph references] in arguments of the functions xref:functions/graph.adoc#functions-graph-byname[`graph.byName`] and xref:functions/graph.adoc#functions-graph-propertiesByName[`graph.propertiesByName`]. | |
| In Cypher 25 the graph references can be passed in without quoting as in the name column from `SHOW ALIASES FOR DATABASE`. | |
| Note that escaping graph names within the graph functions string argument is not supported in Cypher 5. |
Usually we split the lines between sentences and not in the middle of sentences
There was a problem hiding this comment.
Ah...I guess there are no deprecations in cypher 25 yet. So this is about what we newly support. I'll try to reformulate this a little.
There was a problem hiding this comment.
I guess we would want to also add something for the removal of the old deprecation and introduction of the new + the breaking change, might be easier to just have that in this PR as well to not need 2 graph ref related cypher manual docs PRs 🤔
There was a problem hiding this comment.
Woudn't it be better to port Louise's changes to this branch instead of doing them twice?
There was a problem hiding this comment.
We discussed that we can take over the deprecations from neo4j/docs-status-codes#340 after that one is merged. This can also be in a follow up PR.
nadja-muller
force-pushed
the
document-graph-references
branch
from
3726e9a to
efdc42d
Compare
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
Co-authored-by: Jens Pryce-Åklundh <[email protected]>
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
JPryce-Aklundh
approved these changes
Jun 16, 2025
Hunterness
approved these changes
Jun 16, 2025
JPryce-Aklundh
added a commit
that referenced
this pull request
Jun 24, 2025
see also: * #1315 * https://github.com/neo4j/docs-status-codes/pull/340/files * #1295 --------- Co-authored-by: Jens Pryce-Åklundh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.