Add dynamic label and type support in label expressions #1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gem-neo4j
force-pushed
the
dev_add_dynamic_label_expressions
branch
from
2eb812c to
568655e
Compare
hvub
reviewed
Jul 9, 2025
hvub
approved these changes
Jul 9, 2025
Contributor
hvub
left a comment
hvub
left a comment
There was a problem hiding this comment.
As a baseline I think that is perfectly fine.
General oberservation:
- Predicates for not link label expression, nor have dedicates entry for the label expression predicate.
- There is link to label expression on the main expression page.
That is improvable, but certainly outside of this PR.
If there is the idea to give more love the dynamic label expression documentation, then such refinements can be part of that.
rsill-neo4j
reviewed
Jul 9, 2025
modules/ROOT/pages/deprecations-additions-removals-compatibility.adoc
Outdated
Show resolved
Hide resolved
rsill-neo4j
reviewed
Jul 16, 2025
Contributor
rsill-neo4j
left a comment
rsill-neo4j
left a comment
There was a problem hiding this comment.
added suggestions for tags + include for the duplicated section
Collaborator
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
rsill-neo4j
added a commit
that referenced
this pull request
Jul 31, 2025
This reverts commit 1ccfc70.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wasn't sure how much to add for this feature, it is good to be mentioned, but as we have no central place for dynamic labels and types it makes it tricky to find good places to add it