-
Notifications
You must be signed in to change notification settings - Fork 64
Update descriptions in show index columns #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
was missing vector type and the entity type values was odd (now they're aligned with the constraints one and more accurate to what values it actually returns)
also on the allowed types section on the main constraint page and not just the syntax page (it was mentioned in the example but not by the type list) unrelated to the index bits, but something I noticed on the constraint PR but that didn't get updated before it was merged
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
one small suggestion + approval
|
|
||
| [NOTE] | ||
| Because storing lists of xref:values-and-types/vector.adoc[`VECTOR`] values is not supported, property type constraints cannot be created for `LIST<VECTOR<TYPE>(DIMENSION) NOT NULL>`. | ||
| Additionally, `VECTOR` property type constraints must be created with a specific dimension and coordinate value, where the dimension must be greater than `0` and less or equal to `4096`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Additionally, `VECTOR` property type constraints must be created with a specific dimension and coordinate value, where the dimension must be greater than `0` and less or equal to `4096`. | |
| Additionally, `VECTOR` property type constraints must be created with a specific dimension and coordinate value, where the dimension must be greater than `0` and less than or equal to `4096`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I copied this directly from the syntax page, do you want me to update it there too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated in both
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
|
also applied this to #1406 (graph types) |
was missing vector type in the index type column and the entity type values were odd (now they're aligned with the constraints one and more accurate to what values it actually returns)
the vector in the index type column should have been added when vector indexes were introduced, the entity type column update is just general from the beginning of show indexes.
the vector property type constraint update is only relevant for cypher 25 after the vector type was released