-
Notifications
You must be signed in to change notification settings - Fork 64
PLAN-2443 - Include allReduce in the Pattern docs where QPPs are described #1407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -380,6 +380,10 @@ For example, all relationships in the path must be of type `EMPLOYED_BY`. | |||||
| * Nodes or relationships must have properties satisfying some condition. | ||||||
| For example, all relationships must have the property `distance > 10`. | ||||||
|
|
||||||
| * For every iteration of the QPP, an aggregated value over the constructed path so far should satisfy a predicate. | ||||||
|
||||||
| * For every iteration of the QPP, an aggregated value over the constructed path so far should satisfy a predicate. | |
| * For every iteration of the quantified path pattern, an aggregated value over the constructed path so far should satisfy a predicate. |
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would avoid mentioning SHORTEST here, it muddies the water. We don't want to suggest the association of SHORTEST with allReduce().
Like in the previous example we say "This works fine where the solution is known to lie within some range of hops.", here I would say that I pick a known upper bound of 6.05 or maybe even 7 or 10 for the total distance. I wouldn't specify how I know it to be a reasonable upper bound.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make it a bit longer and as a follow-up sentence, not between prentheses.