Skip to content

Conversation

@rsill-neo4j
Copy link
Contributor

No description provided.

Copy link
Contributor

@lidiazuin lidiazuin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few suggestions!

----

These `delete` mutations and response types should be generated:
The following `delete` mutations and response types are generated:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why the mutation is here written in lowercase? It could be helpful to find a rule for that, but I think generally we write clauses/operations in uppercase.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... on second thought, not so sure actually
in code listings, it's a prefix and then it's used as lower case (deletePosts for Post objects)

for mutations, it's used consistently as lower case actually (create, delete and update are all written like this)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, whatever works best! I was just wondering because there are some cases where they are written in uppercase.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Oct 14, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@rsill-neo4j rsill-neo4j merged commit 56618c7 into 5.x Oct 21, 2024
6 checks passed
@github-actions
Copy link

💔 All backports failed

Status Branch Result
6.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

backport --pr 185

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details

@rsill-neo4j rsill-neo4j deleted the nit-picky branch April 2, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants