Skip to content

adds a note about using aggregate with pagination#290

Merged
angrykoala merged 2 commits into7.xfrom
aggregate-with-pagination
Feb 12, 2026
Merged

adds a note about using aggregate with pagination#290
angrykoala merged 2 commits into7.xfrom
aggregate-with-pagination

Conversation

@angrykoala
Copy link
Member

Adds a note about the behaviour of aggregate when using first and after pagination.

This PR also fixes two incorrect examples of aggregate

This is a draft PR until we confirm this is the desired behaviour

Copy link
Contributor

@rsill-neo4j rsill-neo4j left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example doesn't show the optional arguments

do i understand correctly that you can add first and after but then the cursor does nothing? could we show that?

Copy link
Contributor

@MacondoExpress MacondoExpress left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@angrykoala angrykoala marked this pull request as ready for review February 11, 2026 13:31
Co-authored-by: Richard Sill <156673635+rsill-neo4j@users.noreply.github.com>
@angrykoala
Copy link
Member Author

@rsill-neo4j

Indeed, the cursor won't act on aggregates either, would you mean adding another example or changing what we have?

I'm worried that adding the cursor may make the behaviour harder to understand

@rsill-neo4j
Copy link
Contributor

@rsill-neo4j

Indeed, the cursor won't act on aggregates either, would you mean adding another example or changing what we have?

I'm worried that adding the cursor may make the behaviour harder to understand

maybe another query at the bottom, saying

"even if the query has a cursor, the result would still be the same.
[query listing]"

?

@angrykoala
Copy link
Member Author

I've added a brief note, another example feels a bit much just to mention that after is also ignored

@angrykoala angrykoala merged commit 099d76c into 7.x Feb 12, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants