Add `DROP DATABASE name CASCADE ALIASES` #1805

Hunterness · 2024-09-03T10:52:33Z

to drop any aliases blocking the deletion of the database

Documenting https://github.com/neo-technology/neo4j/pull/26465, ~~needs to wait until that has been merged.~~

to drop any aliases blocking the deletion of the database

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

Co-authored-by: Mark Dixon <[email protected]>

Hunterness · 2024-09-19T12:08:27Z

@renetapopova I guess you are busy with the linked users PR, but I'm just looking at the status of my open PRs and want to know that this one hasn't been forgotten about :)

renetapopova · 2024-09-19T12:10:50Z

@renetapopova I guess you are busy with the linked users PR, but I'm just looking at the status of my open PRs and want to know that this one hasn't been forgotten about :)

Actually, I added some comments, but I wanted to look at it again. I'll submit them now and look at the PR again later today.

renetapopova

I added some suggestions.

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

Hunterness · 2024-09-19T12:41:32Z

Actually, I added some comments, but I wanted to look at it again. I'll submit them now and look at the PR again later today.

I've updated some of them so hopefully that helps when looking at it again

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

…delete-databases.adoc

…/delete-composite-databases.adoc

…delete-databases.adoc

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

Hunterness · 2024-09-24T13:28:54Z

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

+
+This behavior is the same for the more general command `DROP DATABASE name` when using it to drop a composite database.
+
+The option `RESTRICT` explicitly requests the default behavior of the command.


since this section don't have a syntax description nor mention RESTRICT before this point, this sentence sticks out weirdly

Yes, I had this question in my mind: What is the default behavior of the command?

to throw an error when there exists aliases (for composite its constituent aliases and for standard it's local ones targeting it), so the behaviour if you don't write CASCADE ALIASES

Ah ok. And when or why would one use it?

I don't really see people using it as it means the same as leaving it out, but it is there for consistency. We do allow you to specify the default behaviours of DUMP DATA/NOWAIT so why wouldn't we allow you to specify RESTRICT

I am not sure what to write then. I'll leave it out until we come up with something useful for the user.

I think leaving it out on the composite page is fine

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

renetapopova

I think it looks good now. @Hunterness, could you please take a look? Thanks

…/delete-composite-databases.adoc Co-authored-by: Therese Magnusson <[email protected]>

…delete-databases.adoc Co-authored-by: Therese Magnusson <[email protected]>

Hunterness

this I think would fix the example formatting

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

renetapopova · 2024-09-24T14:04:02Z

@Hunterness, any final comments?

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

Hunterness · 2024-09-24T15:04:07Z

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

+
+This behavior is the same for the more general command `DROP DATABASE name` when using it to drop a composite database.
+
+The option `RESTRICT` explicitly requests the default behavior of the command.


I don't really see people using it as it means the same as leaving it out, but it is there for consistency. We do allow you to specify the default behaviours of DUMP DATA/NOWAIT so why wouldn't we allow you to specify RESTRICT

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

…delete-databases.adoc

…/delete-composite-databases.adoc

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc

…delete-databases.adoc Co-authored-by: Therese Magnusson <[email protected]>

neo-technology-commit-status-publisher · 2024-09-24T15:17:17Z

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

Companion Pr to neo4j/docs-operations#1805, ~~should probably wait for that to go in.~~ Documenting neo-technology/neo4j#26465, ~~needs to wait until that has been merged.~~ --------- Co-authored-by: Jens Pryce-Åklundh <[email protected]>

to drop any aliases blocking the deletion of the database Documenting neo-technology/neo4j#26465, ~~needs to wait until that has been merged.~~ --------- Co-authored-by: Mark Dixon <[email protected]> Co-authored-by: Reneta Popova <[email protected]>

Add DROP DATABASE name CASCADE ALIASES

488a86d

to drop any aliases blocking the deletion of the database

Hunterness added DO NOT MERGE team-cypher-operations labels Sep 3, 2024

Hunterness mentioned this pull request Sep 3, 2024

Added DROP DATABASE name CASCADE ALIASES neo4j/docs-cypher#1036

Merged

Hunterness commented Sep 3, 2024

View reviewed changes

Add sentences about additional privileges

5b7e27e

mnd999 self-assigned this Sep 4, 2024

mnd999 requested changes Sep 4, 2024

View reviewed changes

Hunterness and others added 2 commits September 4, 2024 12:29

Apply suggestions from code review

994f3b9

Co-authored-by: Mark Dixon <[email protected]>

Address review comments

41be4e4

Hunterness added 5.24 and removed DO NOT MERGE labels Sep 9, 2024

renetapopova self-requested a review September 9, 2024 11:11

mnd999 approved these changes Sep 17, 2024

View reviewed changes

renetapopova requested changes Sep 19, 2024

View reviewed changes

Address review comments

821a506

renetapopova reviewed Sep 19, 2024

View reviewed changes

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc Show resolved Hide resolved

Hunterness and others added 7 commits September 20, 2024 08:40

update examples slightly

6b05ee1

Update modules/ROOT/pages/database-administration/standard-databases/…

767b535

…delete-databases.adoc

Update modules/ROOT/pages/database-administration/standard-databases/…

32a35f9

…delete-databases.adoc

Update modules/ROOT/pages/database-administration/composite-databases…

2c5af59

…/delete-composite-databases.adoc

Update modules/ROOT/pages/database-administration/composite-databases…

4023823

…/delete-composite-databases.adoc

Update modules/ROOT/pages/database-administration/standard-databases/…

c42b313

…delete-databases.adoc

editial update of delete composite database page

99ed2bc

Hunterness commented Sep 24, 2024

View reviewed changes

renetapopova approved these changes Sep 24, 2024

View reviewed changes

Update modules/ROOT/pages/database-administration/composite-databases…

8ed9ecd

…/delete-composite-databases.adoc Co-authored-by: Therese Magnusson <[email protected]>

renetapopova and others added 2 commits September 24, 2024 14:35

Update modules/ROOT/pages/database-administration/standard-databases/…

c670df8

…delete-databases.adoc Co-authored-by: Therese Magnusson <[email protected]>

Update modules/ROOT/pages/database-administration/standard-databases/…

a2e6614

…delete-databases.adoc Co-authored-by: Therese Magnusson <[email protected]>

Hunterness commented Sep 24, 2024

View reviewed changes

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc Outdated Show resolved Hide resolved

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc Outdated Show resolved Hide resolved

renetapopova added 2 commits September 24, 2024 15:51

fix the example and the label

1afc7d8

remove we

41a79e8

Hunterness commented Sep 24, 2024

View reviewed changes

renetapopova reviewed Sep 24, 2024

View reviewed changes

modules/ROOT/pages/database-administration/composite-databases/delete-composite-databases.adoc Outdated Show resolved Hide resolved

renetapopova reviewed Sep 24, 2024

View reviewed changes

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc Outdated Show resolved Hide resolved

renetapopova added 2 commits September 24, 2024 16:09

Update modules/ROOT/pages/database-administration/standard-databases/…

b714145

…delete-databases.adoc

Update modules/ROOT/pages/database-administration/composite-databases…

31d1e6b

…/delete-composite-databases.adoc

Hunterness commented Sep 24, 2024

View reviewed changes

modules/ROOT/pages/database-administration/standard-databases/delete-databases.adoc Show resolved Hide resolved

Update modules/ROOT/pages/database-administration/standard-databases/…

5b88e8c

…delete-databases.adoc Co-authored-by: Therese Magnusson <[email protected]>

renetapopova merged commit a809d33 into neo4j:dev Sep 24, 2024
8 checks passed


		This behavior is the same for the more general command `DROP DATABASE name` when using it to drop a composite database.

		The option `RESTRICT` explicitly requests the default behavior of the command.

Uh oh!

Add DROP DATABASE name CASCADE ALIASES #1805

Add DROP DATABASE name CASCADE ALIASES #1805

Uh oh!

Conversation

Hunterness commented Sep 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hunterness commented Sep 19, 2024

Uh oh!

renetapopova commented Sep 19, 2024

Uh oh!

renetapopova left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Hunterness commented Sep 19, 2024

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

renetapopova left a comment

Choose a reason for hiding this comment

Uh oh!

Hunterness left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

renetapopova commented Sep 24, 2024

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

neo-technology-commit-status-publisher commented Sep 24, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Add `DROP DATABASE name CASCADE ALIASES` #1805

Add `DROP DATABASE name CASCADE ALIASES` #1805

Hunterness commented Sep 3, 2024 •

edited

Loading

neo-technology-commit-status-publisher commented Sep 24, 2024 •

edited

Loading