Skip to content

add version label to property rules #1818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2024
Merged

add version label to property rules #1818

merged 3 commits into from
Sep 18, 2024

Conversation

@phil198
Copy link
Contributor

@phil198 phil198 commented Sep 18, 2024

add [role=label--new-5.21] version label to property rules

@phil198 phil198 force-pushed the property-rules-version-and-additions branch from a717846 to a889aa7 Compare September 18, 2024 10:44
@phil198 phil198 force-pushed the property-rules-version-and-additions branch from a889aa7 to 438f0b4 Compare September 18, 2024 11:02
renetapopova
renetapopova requested changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @phil198. I think they should be part of the same attribute to be rendered.

@phil198
Copy link
Contributor Author

phil198 commented Sep 18, 2024

thanks @renetapopova . For some reason it still doesn't render https://neo4j-docs-operations-1818.surge.sh/operations-manual/5/authentication-authorization/property-based-access-control/. Any ideas?

@renetapopova
Copy link
Collaborator

thanks @renetapopova . For some reason it still doesn't render https://neo4j-docs-operations-1818.surge.sh/operations-manual/5/authentication-authorization/property-based-access-control/. Any ideas?

Ah, that's because it is on the top level. I didn't notice that when I looked at it before.

@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Sep 18, 2024 •
edited
Loading

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova self-requested a review September 18, 2024 14:45
renetapopova
renetapopova approved these changes Sep 18, 2024
View reviewed changes
Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good now.

@phil198
Copy link
Contributor Author

phil198 commented Sep 18, 2024

I think it looks good now.

Thanks @renetapopova

@phil198 phil198 merged commit 8a51736 into neo4j:dev Sep 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@renetapopova renetapopova renetapopova approved these changes

Assignees

No one assigned

Labels

cherry-pick-this-to-5.x team-cypher-operations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@phil198 @renetapopova @neo-technology-commit-status-publisher