Skip to content

Conversation

@meistermeier
Copy link
Contributor

The Parquet file support for neo4j admin import will come out in on of the next minor versions as a preview feature.
Depending on the feedback we get from customers and users, there will be definitely coming more (also to the docs).
This is a quite defensive change to avoid promising too much but also pointing out that this feature exists at all ;)

Because the feature itself is not merged yet, I added the DO NOT MERGE label.
Please let us get this into a shape where we can just merge it after the feature went into the product, thanks.

@fbiville
Copy link
Contributor

Just to be extra explicit: the feature has been merged so this PR can be reviewed/merged too.

@renetapopova renetapopova self-assigned this Oct 10, 2024
@renetapopova
Copy link
Collaborator

renetapopova commented Oct 10, 2024

Just to be extra explicit: the feature has been merged so this PR can be reviewed/merged too.

I am reviewing the PR now, but I see that @meistermeier is on vacation. So, I'll just push my editorial and style changes into the PR. We can always discuss and improve them later when he is back. Having said that, I'll still need someone to review my commit.

@renetapopova
Copy link
Collaborator

Also, I need to see why the test is failing.

Copy link
Collaborator

@renetapopova renetapopova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks good now, but we need to make sure the test is green before merging it.

@fbiville
Copy link
Contributor

@renetapopova I'm covering for @meistermeier. I can work on any updates you deem necessary.

@renetapopova
Copy link
Collaborator

@renetapopova I'm covering for @meistermeier. I can work on any updates you deem necessary.

Ah, cool! As I said, I pushed some editorial updates if you want to take a look, but I think the content looks good for merging. However, the test neo4j-admin tools (PRs) (Testing)—TeamCity build failed, so I'll wait for a few other PRs to be merged first, rebase this one, and then investigate further if the test is still failing.

Move unsupported parameters by the Parquet importer to their
own section.
@neo-technology-commit-status-publisher
Copy link
Collaborator

neo-technology-commit-status-publisher commented Oct 15, 2024

Thanks for the documentation updates.

The preview documentation has now been torn down - reopening this PR will republish it.

@renetapopova renetapopova removed the 5.25 label Oct 16, 2024
@renetapopova
Copy link
Collaborator

Closing this one as duplicate.

@renetapopova renetapopova added duplicate This issue or pull request already exists and removed DO NOT MERGE labels Oct 16, 2024
renetapopova added a commit that referenced this pull request Nov 15, 2024
…1858)

The Parquet file support for neo4j admin import will come out in on of
the next minor versions as a preview feature.
Depending on the feedback we get from customers and users, there will be
definitely coming more (also to the docs).
This is a quite defensive change to avoid promising too much but also
pointing out that this feature exists at all ;)

Because the feature itself is not merged yet, I added the DO NOT MERGE
label.
Please let us get this into a shape where we can just merge it after the
feature went into the product, thanks.


This supersedes #1850

---------

Co-authored-by: Gerrit Meier <[email protected]>
Co-authored-by: Reneta Popova <[email protected]>
@meistermeier meistermeier deleted the parquet-import branch February 18, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants