-
Notifications
You must be signed in to change notification settings - Fork 83
Add neo4j-admin-import section and parameter details for Parquet. #1850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Just to be extra explicit: the feature has been merged so this PR can be reviewed/merged too. |
I am reviewing the PR now, but I see that @meistermeier is on vacation. So, I'll just push my editorial and style changes into the PR. We can always discuss and improve them later when he is back. Having said that, I'll still need someone to review my commit. |
|
Also, I need to see why the test is failing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good now, but we need to make sure the test is green before merging it.
|
@renetapopova I'm covering for @meistermeier. I can work on any updates you deem necessary. |
Ah, cool! As I said, I pushed some editorial updates if you want to take a look, but I think the content looks good for merging. However, the |
1ab00ee to
2942f72
Compare
Move unsupported parameters by the Parquet importer to their own section.
|
Thanks for the documentation updates. The preview documentation has now been torn down - reopening this PR will republish it. |
|
Closing this one as duplicate. |
…1858) The Parquet file support for neo4j admin import will come out in on of the next minor versions as a preview feature. Depending on the feedback we get from customers and users, there will be definitely coming more (also to the docs). This is a quite defensive change to avoid promising too much but also pointing out that this feature exists at all ;) Because the feature itself is not merged yet, I added the DO NOT MERGE label. Please let us get this into a shape where we can just merge it after the feature went into the product, thanks. This supersedes #1850 --------- Co-authored-by: Gerrit Meier <[email protected]> Co-authored-by: Reneta Popova <[email protected]>
The Parquet file support for neo4j admin import will come out in on of the next minor versions as a preview feature.
Depending on the feedback we get from customers and users, there will be definitely coming more (also to the docs).
This is a quite defensive change to avoid promising too much but also pointing out that this feature exists at all ;)
Because the feature itself is not merged yet, I added the DO NOT MERGE label.
Please let us get this into a shape where we can just merge it after the feature went into the product, thanks.